Skip to content

Commit e11e26a

Browse files
committed
Show builders without detected problems
Only 3 builds are shown for these. Also, reduce the number of builds shown from 70 to 50. Add an ellipsis if some are hidden.
1 parent 5aa8e17 commit e11e26a

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

master/custom/release_dashboard.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,10 @@ def problems(self):
303303
problems = []
304304
for builder in self._root.builders:
305305
if builder.branch == self:
306-
problems.extend(builder.problems)
306+
if builder.problems:
307+
problems.extend(builder.problems)
308+
else:
309+
problems.append(NoProblem(builder))
307310
return problems
308311

309312
@cached_property
@@ -682,8 +685,11 @@ def get_severity_and_description(self):
682685
return severity, description
683686

684687

688+
@dataclass
685689
class NoProblem(Problem):
686690
"""Dummy problem"""
691+
builder: Builder | None = None
692+
687693
name = "Releasable"
688694

689695
description = "No problem detected"

master/custom/templates/releasedashboard.html

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,10 @@ <h5>
206206
</div>
207207
{% endif %}
208208
<div class="build-dots">
209-
{% for build in builder.builds[:70] %}
209+
{% for build in builder.builds %}
210+
{% if loop.index0 == (50 if builder.problems else 3) %}
211+
⋯ {% break %}
212+
{% endif %}
210213
{{ build_dot(build) }}
211214
{% endfor %}
212215
</div>

0 commit comments

Comments
 (0)