Fix the dashboard (#609)

Always yield a BuildFailure for failing builders.

BuildFailure now allows the latest & breaking build to be the same,
and deduplicates in that case.

Also, show builders without detected problems
Only 3 builds are shown for these.

Also, reduce the number of builds shown from 70 to 50.
Add an ellipsis if some are hidden.

Author: encukou

master/custom/release_dashboard.py

@@ -228,18 +228,17 @@ def problems(self):
         elif latest_build["results"] == buildbot.process.results.WARNINGS:
             yield BuildWarning(latest_build)
         elif latest_build["results"] == buildbot.process.results.FAILURE:
-            failing_streak = 0
             first_failing_build = None
             for build in self.iter_interesting_builds():
                 if build["results"] == buildbot.process.results.FAILURE:
                     first_failing_build = build
-                    continue
                 elif build["results"] == buildbot.process.results.SUCCESS:
-                    if latest_build != first_failing_build:
-                        yield BuildFailure(latest_build, first_failing_build)
                     break
             else:
-                yield BuildFailure(latest_build)
+                # Didn't find a successful build; end of the failing streak
+                # is unknown.
+                first_failing_build = None
+            yield BuildFailure(latest_build, first_failing_build)
 
         if not self.connected_workers:
             yield BuilderDisconnected(self)
@@ -304,7 +303,10 @@ def problems(self):
         problems = []
         for builder in self._root.builders:
             if builder.branch == self:
-                problems.extend(builder.problems)
+                if builder.problems:
+                    problems.extend(builder.problems)
+                else:
+                    problems.append(NoProblem(builder))
         return problems
 
     @cached_property
@@ -619,8 +621,9 @@ def builder(self):
     @cached_property
     def affected_builds(self):
         result = {"Latest build": self.latest_build}
-        if self.first_failing_build:
-            result["Breaking build"] = self.first_failing_build
+        first_failing = self.first_failing_build
+        if first_failing and first_failing != self.latest_build:
+            result["Breaking build"] = first_failing
         return result
 
 
@@ -682,8 +685,11 @@ def get_severity_and_description(self):
         return severity, description
 
 
+@dataclass
 class NoProblem(Problem):
     """Dummy problem"""
+    builder: 'Builder | None' = None
+
     name = "Releasable"
 
     description = "No problem detected"

master/custom/templates/releasedashboard.html

@@ -206,7 +206,10 @@ <h5>
                                         </div>
                                     {% endif %}
                                     <div class="build-dots">
-                                        {% for build in builder.builds[:70] %}
+                                        {% for build in builder.builds %}
+                                            {% if loop.index0 == (50 if builder.problems else 3) %}
+                                                ⋯ {% break %}
+                                            {% endif %}
                                             {{ build_dot(build) }}
                                         {% endfor %}
                                     </div>