Skip to content

Commit 00d4267

Browse files
committed
fixup! Avoid unbounded growth SpooledTempfile.writelines
1 parent a88c783 commit 00d4267

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

Lib/tempfile.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -848,17 +848,17 @@ def write(self, s):
848848
return rv
849849

850850
def writelines(self, iterable):
851-
if self._max_size and not self._rolled:
852-
it = iter(iterable)
851+
if self._max_size == 0 or self._rolled:
852+
return self._file.writelines(iterable)
853853

854-
for line in it:
855-
self.write(line)
856-
if self._rolled:
857-
break
854+
it = iter(iterable)
858855

859-
return self._file.writelines(it)
860-
else:
861-
return self._file.writelines(iterable)
856+
for line in it:
857+
self.write(line)
858+
if self._rolled:
859+
break
860+
861+
return self._file.writelines(it)
862862

863863
def detach(self):
864864
return self._file.detach()

0 commit comments

Comments
 (0)