Apply suggestions from code review

eendebakpt · markshannon · web-flow · commit 068a16acd258 · 2024-12-11T20:04:22.000+01:00
Co-authored-by: Mark Shannon &lt;mark@hotpy.org&gt;
diff --git a/Include/internal/pycore_long.h b/Include/internal/pycore_long.h
@@ -157,7 +157,7 @@ PyAPI_FUNC(int) _PyLong_Size_t_Converter(PyObject *, void *);
 
 /* Long value tag bits:
  * 0-1: Sign bits value = (1-sign), ie. negative=2, positive=0, zero=1.
- * 2: Reserved for immortality bit. Set to 1 for the small ints
+ * 2: Set to 1 for the small ints
  * 3+ Unsigned digit count
  */
 #define SIGN_MASK 3
diff --git a/Objects/longobject.c b/Objects/longobject.c
@@ -3617,7 +3617,7 @@ _long_is_small_int(PyObject *op)
 {
     PyLongObject *long_object = (PyLongObject *)op;
 
-    return (int)(long_object->long_value.lv_tag & IMMORTALITY_BIT_MASK);
+    return (long_object->long_value.lv_tag & IMMORTALITY_BIT_MASK) != 0;
 }
 
 static void

Original file line number	Diff line number	Diff line change
`@@ -3617,7 +3617,7 @@ _long_is_small_int(PyObject *op)`
`3617`	`3617`	`{`
`3618`	`3618`	`PyLongObject long_object = (PyLongObject )op;`
`3619`	`3619`
`3620`		`- return (int)(long_object->long_value.lv_tag & IMMORTALITY_BIT_MASK);`
	`3620`	`+ return (long_object->long_value.lv_tag & IMMORTALITY_BIT_MASK) != 0;`
`3621`	`3621`	`}`
`3622`	`3622`
`3623`	`3623`	`static void`