review comment

eendebakpt · eendebakpt · commit 0b97604bcd2e · 2025-10-24T14:30:30.000+02:00
diff --git a/Modules/_testcapimodule.c b/Modules/_testcapimodule.c
@@ -2441,7 +2441,7 @@ test_pyset_add(PyObject* self, PyObject *Py_UNUSED(args))
 {
 
     PyObject *set = NULL, *empty_tuple=NULL, *tracked_object;
-
+    int return_value;
 
     tracked_object = PyImport_ImportModule("sys");
     if (tracked_object == NULL) {
@@ -2452,15 +2452,13 @@ test_pyset_add(PyObject* self, PyObject *Py_UNUSED(args))
         goto failed;
     }
 
-
-    int return_value;
     empty_tuple = PyTuple_New(0);
     if (empty_tuple == NULL) {
         goto failed;
     }
     set = PyFrozenSet_New(empty_tuple);
     if (set == NULL) {
-        return NULL;
+        goto failed;
     }
 
     if (PyObject_GC_IsTracked(set)) {

Original file line number	Diff line number	Diff line change
`@@ -2441,7 +2441,7 @@ test_pyset_add(PyObject* self, PyObject *Py_UNUSED(args))`
`2441`	`2441`	`{`
`2442`	`2442`
`2443`	`2443`	`PyObject set = NULL, empty_tuple=NULL, *tracked_object;`
`2444`		`-`
	`2444`	`+ int return_value;`
`2445`	`2445`
`2446`	`2446`	`tracked_object = PyImport_ImportModule("sys");`
`2447`	`2447`	`if (tracked_object == NULL) {`
`@@ -2452,15 +2452,13 @@ test_pyset_add(PyObject* self, PyObject *Py_UNUSED(args))`
`2452`	`2452`	`goto failed;`
`2453`	`2453`	`}`
`2454`	`2454`
`2455`		`-`
`2456`		`- int return_value;`
`2457`	`2455`	`empty_tuple = PyTuple_New(0);`
`2458`	`2456`	`if (empty_tuple == NULL) {`
`2459`	`2457`	`goto failed;`
`2460`	`2458`	`}`
`2461`	`2459`	`set = PyFrozenSet_New(empty_tuple);`
`2462`	`2460`	`if (set == NULL) {`
`2463`		`- return NULL;`
	`2461`	`+ goto failed;`
`2464`	`2462`	`}`
`2465`	`2463`
`2466`	`2464`	`if (PyObject_GC_IsTracked(set)) {`