Raise ValueError for size() with trackfd=False.

Author: serhiy-storchaka

Lib/test/test_mmap.py

@@ -281,9 +281,13 @@ def test_trackfd_parameter(self, close_original_fd):
                 if close_original_fd:
                     f.close()
                 self.assertEqual(len(m), size)
-                with self.assertRaises(OSError) as err_cm:
-                    m.size()
-                self.assertEqual(err_cm.exception.errno, errno.EBADF)
+                if os.name == 'nt':
+                    with self.assertRaises(ValueError):
+                        m.size()
+                else:
+                    with self.assertRaises(OSError) as err_cm:
+                        m.size()
+                    self.assertEqual(err_cm.exception.errno, errno.EBADF)
                 with self.assertRaises(ValueError):
                     m.resize(size * 2)
                 with self.assertRaises(ValueError):

Modules/mmapmodule.c

@@ -716,7 +716,7 @@ mmap_size_method(PyObject *op, PyObject *Py_UNUSED(ignored))
     CHECK_VALID(NULL);
 
 #ifdef MS_WINDOWS
-    if (self->file_handle != INVALID_HANDLE_VALUE || !self->trackfd) {
+    if (self->file_handle != INVALID_HANDLE_VALUE) {
         DWORD low,high;
         long long size;
         low = GetFileSize(self->file_handle, &high);
@@ -731,8 +731,12 @@ mmap_size_method(PyObject *op, PyObject *Py_UNUSED(ignored))
             return PyLong_FromLong((long)low);
         size = (((long long)high)<<32) + low;
         return PyLong_FromLongLong(size);
-    } else {
+    else if (self->trackfd) {
         return PyLong_FromSsize_t(self->size);
+    } else {
+        PyErr_SetString(PyExc_ValueError,
+            "can't get size with trackfd=False");
+        return NULL;
     }
 #endif /* MS_WINDOWS */