Apply suggestions from code review

Co-authored-by: Sergey B Kirpichev <[email protected]>

Author: ZeroIntensity

Lib/test/test_capi/test_long.py

@@ -211,8 +211,7 @@ def check_long_asintandoverflow(self, func, min_val, max_val):
 
         self.assertEqual(func(min_val - 1), (-1, -1))
         self.assertEqual(func(max_val + 1), (-1, +1))
-        with self.assertRaises(SystemError):
-            func(None)
+        self.assertRaises(SystemError, func, None)
 
         # CRASHES func(1.0)
 

Modules/_testlimitedcapi/long.c

@@ -672,6 +672,7 @@ pylong_aslonglongandoverflow(PyObject *module, PyObject *arg)
     int overflow = UNINITIALIZED_INT;
     long long value = PyLong_AsLongLongAndOverflow(arg, &overflow);
     if (value == -1 && PyErr_Occurred()) {
+        // overflow can be 0 if a seperate exception occurred
         assert(overflow == -1 || overflow == 0);
         return NULL;
     }