[3.14] gh-132983: Use Py_UNREACHABLE in _zstd_load_impl() (GH-137320) (#137360)

miss-islington · Rogdham · web-flow · commit 0fc49bed80f3 · 2025-08-07T18:38:15.000+03:00
Co-authored-by: Rogdham &lt;3994389+Rogdham@users.noreply.github.com&gt;
diff --git a/Modules/_zstd/decompressor.c b/Modules/_zstd/decompressor.c
@@ -157,10 +157,7 @@ _zstd_load_impl(ZstdDecompressor *self, ZstdDict *zd,
                                        zd->dict_len);
     }
     else {
-        /* Impossible code path */
-        PyErr_SetString(PyExc_SystemError,
-                        "load_d_dict() impossible code path");
-        return -1;
+        Py_UNREACHABLE();
     }
 
     /* Check error */

Original file line number	Diff line number	Diff line change
`@@ -157,10 +157,7 @@ _zstd_load_impl(ZstdDecompressor self, ZstdDict zd,`
`157`	`157`	`zd->dict_len);`
`158`	`158`	`}`
`159`	`159`	`else {`
`160`		`- /* Impossible code path */`
`161`		`- PyErr_SetString(PyExc_SystemError,`
`162`		`- "load_d_dict() impossible code path");`
`163`		`- return -1;`
	`160`	`+ Py_UNREACHABLE();`
`164`	`161`	`}`
`165`	`162`
`166`	`163`	`/* Check error */`