address review

Author: skirpichev

Modules/_decimal/_decimal.c

@@ -2340,7 +2340,7 @@ dec_from_long(decimal_state *state, PyTypeObject *type, PyObject *v,
         uint8_t sign = export_long.negative ? MPD_NEG : MPD_POS;
         Py_ssize_t len = export_long.ndigits;
 
-        assert(layout->bits_per_digit <= 32);
+        assert(layout->bits_per_digit < 32);
         assert(layout->digits_order == -1);
         assert(layout->digit_endianness == (PY_LITTLE_ENDIAN ? -1 : 1));
         assert(layout->digit_size == 2 || layout->digit_size == 4);
@@ -3681,9 +3681,9 @@ dec_as_long(PyObject *dec, PyObject *context, int round)
     assert(!mpd_iszero(x));
 
     const PyLongLayout *layout = PyLong_GetNativeLayout();
-    const uint32_t base = (uint32_t)1 << layout->bits_per_digit;
+    uint32_t base = (uint32_t)1 << layout->bits_per_digit;
 
-    assert(layout->bits_per_digit <= 32);
+    assert(layout->bits_per_digit < 32);
     assert(layout->digits_order == -1);
     assert(layout->digit_endianness == (PY_LITTLE_ENDIAN ? -1 : 1));
     assert(layout->digit_size == 2 || layout->digit_size == 4);
@@ -3702,11 +3702,11 @@ dec_as_long(PyObject *dec, PyObject *context, int round)
        occur, i.e. len was obtained by a call to mpd_sizeinbase.  Set digits
        to zero, as size can be overestimated. */
     if (layout->digit_size == 4) {
-        memset(digits, 0, len*sizeof(uint32_t));
+        memset(digits, 0, 4*len);
         n = mpd_qexport_u32((uint32_t **)&digits, len, base, x, &status);
     }
     else {
-        memset(digits, 0, len*sizeof(uint16_t));
+        memset(digits, 0, 2*len);
         n = mpd_qexport_u16((uint16_t **)&digits, len, base, x, &status);
     }
 
@@ -3717,7 +3717,7 @@ dec_as_long(PyObject *dec, PyObject *context, int round)
         return NULL;
     }
 
-    assert(n == len || n == len - 1);
+    assert(n <= len);
     mpd_del(x);
     return PyLongWriter_Finish(writer);
 }