Address reviews

Author: sobolevn

Lib/test/test_ast/test_ast.py

@@ -204,7 +204,7 @@ def test_compilation_of_ast_nodes_with_default_end_position_values(self):
         # Check that compilation doesn't crash. Note: this may crash explicitly only on debug mode.
         compile(tree, "<string>", "exec")
 
-    def test_compilation_of_ast_nodes_with_negative_position_values(self):
+    def test_negative_locations_for_compile(self):
         # See https://github.com/python/cpython/issues/130775
         alias = ast.alias(name='traceback', lineno=0, col_offset=0)
         for attrs in (
@@ -219,11 +219,10 @@ def test_compilation_of_ast_nodes_with_negative_position_values(self):
                 ], type_ignores=[])
 
                 # It used to crash on this step:
-                with self.assertRaisesRegex(
-                    ValueError,
-                    'AST node has invalid location',
-                ):
-                    compile(tree, "<string>", "exec")
+                compile(tree, "<string>", "exec")
+
+                # This also must not crash:
+                ast.parse(tree, optimize=2)
 
     def test_slice(self):
         slc = ast.parse("x[::]").body[0].value.slice

Misc/NEWS.d/next/Core_and_Builtins/2025-03-03-20-02-45.gh-issue-130775.fEM6T-.rst

@@ -1,2 +1 @@
-Validate negative :mod:`ast` locations, we only allow ``-1`` as a special
-value.
+Do not crash on negative ``column`` and ``end_column`` in :mod:`ast` locations.

Python/assemble.c

@@ -297,11 +297,8 @@ write_location_info_entry(struct assembler* a, location loc, int isize)
     int line_delta = loc.lineno - a->a_lineno;
     int column = loc.col_offset;
     int end_column = loc.end_col_offset;
-    // Values are validated in `VALIDATE_POSITIONS` in `ast.c`:
-    assert(column >= -1);
-    assert(end_column >= -1);
     if (column < 0 || end_column < 0) {
-        if (loc.end_lineno == loc.lineno || loc.end_lineno == -1) {
+        if (loc.end_lineno == loc.lineno || loc.end_lineno < 0) {
             write_location_info_no_column(a, isize, line_delta);
             a->a_lineno = loc.lineno;
             return SUCCESS;

Python/ast.c

@@ -40,15 +40,6 @@ static int validate_typeparam(type_param_ty);
                      node->col_offset, node->end_col_offset, node->lineno, node->end_lineno); \
         return 0; \
     } \
-    if (node->lineno < -1 || node->end_lineno < -1 || \
-        node->col_offset < -1 || node->end_col_offset < -1) { \
-        PyErr_Format(PyExc_ValueError, \
-                     "AST node has invalid location: lineno=%d, end_lineno=%d, " \
-                     "col_offset=%d, end_col_offset=%d", \
-                     node->lineno, node->end_lineno, \
-                     node->col_offset, node->end_col_offset); \
-        return 0; \
-    } \
     if (node->lineno == node->end_lineno && node->col_offset > node->end_col_offset) { \
         PyErr_Format(PyExc_ValueError, \
                      "line %d, column %d-%d is not a valid range", \