Address review

efimov-mikhail · efimov-mikhail · commit 14b89e5bc8e6 · 2025-10-23T10:14:30.000+03:00
diff --git a/Include/internal/pycore_stackref.h b/Include/internal/pycore_stackref.h
@@ -289,6 +289,7 @@ _PyStackRef_Borrow(_PyStackRef ref, const char *filename, int linenumber)
 static inline _PyStackRef
 _PyStackRef_FromPyObjectStealMortal(PyObject *obj, const char *filename, int linenumber)
 {
+    assert(obj != NULL);
     assert(!_Py_IsImmortal(obj));
     return _Py_stackref_create(obj, 0, filename, linenumber);
 }
@@ -324,7 +325,7 @@ _PyStackRef_FromPyObjectNewMortal(PyObject *obj, const char *filename, int linen
 {
     assert(obj != NULL);
     assert(!_Py_IsStaticImmortal(obj));
-    Py_XINCREF(obj);
+    Py_INCREF(obj);
     return _Py_stackref_create(obj, 0, filename, linenumber);
 }
 #define PyStackRef_FromPyObjectNewMortal(obj) _PyStackRef_FromPyObjectNewMortal(_PyObject_CAST(obj), __FILE__, __LINE__)

Original file line number	Diff line number	Diff line change
`@@ -289,6 +289,7 @@ _PyStackRef_Borrow(_PyStackRef ref, const char *filename, int linenumber)`
`289`	`289`	`static inline _PyStackRef`
`290`	`290`	`_PyStackRef_FromPyObjectStealMortal(PyObject obj, const char filename, int linenumber)`
`291`	`291`	`{`
	`292`	`+ assert(obj != NULL);`
`292`	`293`	`assert(!_Py_IsImmortal(obj));`
`293`	`294`	`return _Py_stackref_create(obj, 0, filename, linenumber);`
`294`	`295`	`}`
`@@ -324,7 +325,7 @@ _PyStackRef_FromPyObjectNewMortal(PyObject obj, const char filename, int linen`
`324`	`325`	`{`
`325`	`326`	`assert(obj != NULL);`
`326`	`327`	`assert(!_Py_IsStaticImmortal(obj));`
`327`		`- Py_XINCREF(obj);`
	`328`	`+ Py_INCREF(obj);`
`328`	`329`	`return _Py_stackref_create(obj, 0, filename, linenumber);`
`329`	`330`	`}`
`330`	`331`	`#define PyStackRef_FromPyObjectNewMortal(obj) _PyStackRef_FromPyObjectNewMortal(_PyObject_CAST(obj), __FILE__, __LINE__)`