Skip to content

Commit 189feb6

Browse files
Trigger CI recheck for NEWS file
1 parent 742ffde commit 189feb6

File tree

1 file changed

+5
-12
lines changed

1 file changed

+5
-12
lines changed

Lib/test/test_urllib.py

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
"""Regression tests for what was in Python 2's "urllib" module"""
22

33
import urllib.parse
4-
import urllib.request
4+
import urllib.request import _proxy_bypass_winreg_override as proxy_bypass_winreg
55
import urllib.error
66
import http.client
77
import email.message
@@ -1690,17 +1690,10 @@ class ProxyBypassRegistryTests(unittest.TestCase):
16901690
def test_proxy_bypass_registry_trailing_semicolon(self):
16911691
fake_proxy_override = "localhost;*.example.com;"
16921692

1693-
# Monkeypatch registry reader
1694-
original_getproxies_registry = urllib.request.getproxies_registry
1695-
urllib.request.getproxies_registry = lambda: {"no": fake_proxy_override}
1696-
1697-
try:
1698-
self.assertFalse(urllib.request.proxy_bypass("notmatching.com"))
1699-
self.assertTrue(urllib.request.proxy_bypass("localhost"))
1700-
self.assertTrue(urllib.request.proxy_bypass("sub.example.com"))
1701-
finally:
1702-
urllib.request.getproxies_registry = original_getproxies_registry
1703-
1693+
# Directly test the internal function
1694+
self.assertFalse(proxy_bypass_winreg("notmatching.com", fake_proxy_override))
1695+
self.assertTrue(proxy_bypass_winreg("localhost", fake_proxy_override))
1696+
self.assertTrue(proxy_bypass_winreg("sub.example.com", fake_proxy_override))
17041697

17051698
if __name__ == '__main__':
17061699
unittest.main()

0 commit comments

Comments
 (0)