Skip to content

Commit 1977953

Browse files
Apply suggestions from code review
Co-authored-by: Ken Jin <[email protected]>
1 parent 4ad2365 commit 1977953

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

PCbuild/readme.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,14 @@ Building Python using Clang/LLVM
5656
--------------------------------
5757

5858
See https://learn.microsoft.com/en-us/cpp/build/clang-support-msbuild?view=msvc-170
59-
how to install and use clang-cl bundled with Microsoft Visual Studio.
59+
for how to install and use clang-cl bundled with Microsoft Visual Studio.
6060
You can use the IDE to switch to clang-cl for local development,
6161
but because this alters the *.vcxproj files, the recommended way is
6262
to use build.bat:
6363

6464
build.bat "/p:PlatformToolset=ClangCL" "/p:PreferredToolArchitecture=x64"
6565

66-
All other build.bat options remain to work as with MSVC, so this
66+
All other build.bat options continue to work as with MSVC, so this
6767
will create a 64bit release binary. PreferredToolArchitecture is needed,
6868
because msbuild by default selects the 32bit architecture of the toolset,
6969
which uses -m32 as the default target architecture.
@@ -79,8 +79,8 @@ platform toolset, but LLVMToolsVersion has to be set accordingly.
7979
Setting the major version is enough, although you can be specific
8080
and use 18.1.8 in the above example, too.
8181

82-
Even --pgo works out of the box, except you do want to run the PGO task
83-
on a different host than the build host. In this case you must pass
82+
Even --pgo works out of the box. However, if you want to run the PGO task
83+
on a different host than the build host, you must pass
8484
"/p:CLANG_PROFILE_PATH=<relative-path-to-instrumented-dir-on-remote-host>"
8585
in the PGInstrument step to make sure the profile data is generated
8686
into the instrumented directory when running the PGO task.

0 commit comments

Comments
 (0)