Support fnmatch

Author: StanFromIreland

Lib/test/test_tools/i18n_data/skipdocstrings.txt

@@ -2,4 +2,5 @@ fileloc.py
 
 skipdocstrings.py
 messages.py
-messages.py
+messages.py
+test*.py

Lib/test/test_tools/i18n_data/testfile.py

@@ -0,0 +1,2 @@
+def func():
+    """Get the Holy Hand Grenade!"""

Lib/test/test_tools/test_i18n.py

@@ -589,7 +589,7 @@ def extract_from_snapshots():
         'messages.py': (),
         'fileloc.py': ('--docstrings',),
         'docstrings.py': ('--docstrings',),
-        ('docstrings.py', 'skipdocstrings.py', 'docstrings.pot'): ('--docstrings',
+        ('docstrings.py', 'skipdocstrings.py', 'testfile.py', 'docstrings.pot'): ('--docstrings',
              f'--exclude-docstrings={DATA_DIR}{os.path.sep}skipdocstrings.txt'),
         'comments.py': ('--add-comments=i18n:',),
         'custom_keywords.py': ('--keyword=foo', '--keyword=nfoo:1,2',

Tools/i18n/pygettext.py

@@ -131,10 +131,12 @@
         appear on a line by itself in the file.
 
     -X filename
-    --exclude-docstrings=filename
+    --exclude-docstrings=
+        This is only useful in conjunction with the -D option above.
         Specify a file that contains a list of files (one per line) that
-        should not have their docstrings extracted.  This is only useful in
-        conjunction with the -D option above.
+        should not have their docstrings extracted. fnmatch-style patterns are
+        supported.
+
 
 If 'inputfile' is -, standard input is read.
 """
@@ -716,7 +718,7 @@ class Options:
         width = 78
         excludefilename = ''
         docstrings = 0
-        nodocstrings = []
+        nodocstrings = set()
         comment_tags = set()
 
     options = Options()
@@ -769,11 +771,10 @@ class Options:
         elif opt in ('-x', '--exclude-file'):
             options.excludefilename = arg
         elif opt in ('-X', '--exclude-docstrings'):
-            with open(arg, 'r') as nodocstrings_file:
+            with open(arg) as nodocstrings_file:
                 for line in nodocstrings_file:
                     line = line.strip()
-                    if line and line not in options.nodocstrings:
-                        options.nodocstrings.append(line)
+                    options.nodocstrings.add(line)
 
     options.comment_tags = tuple(options.comment_tags)