Rename to PyImport_ImportModuleAttr()

Author: vstinner

Doc/c-api/import.rst

@@ -327,7 +327,7 @@ Importing Modules
    initialization.
 
 
-.. c:function:: PyObject* PyImport_GetModuleAttr(PyObject *mod_name, PyObject *attr_name)
+.. c:function:: PyObject* PyImport_ImportModuleAttr(PyObject *mod_name, PyObject *attr_name)
 
    Import the module *mod_name* and get its attribute *attr_name*.
 
@@ -340,9 +340,9 @@ Importing Modules
 
    .. versionadded:: 3.14
 
-.. c:function:: PyObject* PyImport_GetModuleAttrString(const char *mod_name, const char *attr_name)
+.. c:function:: PyObject* PyImport_ImportModuleAttrString(const char *mod_name, const char *attr_name)
 
-   Similar to :c:func:`PyImport_GetModuleAttr`, but names are UTF-8 encoded
+   Similar to :c:func:`PyImport_ImportModuleAttr`, but names are UTF-8 encoded
    strings instead of Python :class:`str` objects.
 
    .. versionadded:: 3.14

Doc/data/refcounts.dat

@@ -3053,10 +3053,10 @@ _Py_c_sum:Py_complex:::
 _Py_c_sum:Py_complex:left::
 _Py_c_sum:Py_complex:right::
 
-PyImport_GetModuleAttr:PyObject*::+1:
-PyImport_GetModuleAttr:PyObject*:mod_name:0:
-PyImport_GetModuleAttr:PyObject*:attr_name:0:
+PyImport_ImportModuleAttr:PyObject*::+1:
+PyImport_ImportModuleAttr:PyObject*:mod_name:0:
+PyImport_ImportModuleAttr:PyObject*:attr_name:0:
 
-PyImport_GetModuleAttrString:PyObject*::+1:
-PyImport_GetModuleAttrString:const char *:mod_name::
-PyImport_GetModuleAttrString:const char *:attr_name::
+PyImport_ImportModuleAttrString:PyObject*::+1:
+PyImport_ImportModuleAttrString:const char *:mod_name::
+PyImport_ImportModuleAttrString:const char *:attr_name::

Doc/whatsnew/3.14.rst

@@ -1301,8 +1301,8 @@ New features
   bit-packing Python version numbers.
   (Contributed by Petr Viktorin in :gh:`128629`.)
 
-* Add :c:func:`PyImport_GetModuleAttr` and
-  :c:func:`PyImport_GetModuleAttrString` helper functions to import a module
+* Add :c:func:`PyImport_ImportModuleAttr` and
+  :c:func:`PyImport_ImportModuleAttrString` helper functions to import a module
   and get an attribute of the module.
   (Contributed by Victor Stinner in :gh:`128911`.)
 

Include/cpython/import.h

@@ -24,9 +24,9 @@ struct _frozen {
 
 PyAPI_DATA(const struct _frozen *) PyImport_FrozenModules;
 
-PyAPI_FUNC(PyObject*) PyImport_GetModuleAttr(
+PyAPI_FUNC(PyObject*) PyImport_ImportModuleAttr(
     PyObject *mod_name,
     PyObject *attr_name);
-PyAPI_FUNC(PyObject*) PyImport_GetModuleAttrString(
+PyAPI_FUNC(PyObject*) PyImport_ImportModuleAttrString(
     const char *mod_name,
     const char *attr_name);

Lib/test/test_capi/test_import.py

@@ -318,58 +318,58 @@ def test_executecodemoduleobject(self):
         # CRASHES execute_code_func(NULL, code, NULL, NULL)
         # CRASHES execute_code_func(name, NULL, NULL, NULL)
 
-    def check_getmoduleattr(self, getmoduleattr):
-        self.assertIs(getmoduleattr('sys', 'argv'), sys.argv)
-        self.assertIs(getmoduleattr('types', 'ModuleType'), types.ModuleType)
+    def check_importmoduleattr(self, importmoduleattr):
+        self.assertIs(importmoduleattr('sys', 'argv'), sys.argv)
+        self.assertIs(importmoduleattr('types', 'ModuleType'), types.ModuleType)
 
         # module name containing a dot
-        attr = getmoduleattr('email.message', 'Message')
+        attr = importmoduleattr('email.message', 'Message')
         from email.message import Message
         self.assertIs(attr, Message)
 
         with self.assertRaises(ImportError):
             # nonexistent module
-            getmoduleattr('nonexistentmodule', 'attr')
+            importmoduleattr('nonexistentmodule', 'attr')
         with self.assertRaises(AttributeError):
             # nonexistent attribute
-            getmoduleattr('sys', 'nonexistentattr')
+            importmoduleattr('sys', 'nonexistentattr')
         with self.assertRaises(AttributeError):
             # attribute name containing a dot
-            getmoduleattr('sys', 'implementation.name')
+            importmoduleattr('sys', 'implementation.name')
 
-    def test_getmoduleattr(self):
-        # Test PyImport_GetModuleAttr()
-        getmoduleattr = _testcapi.PyImport_GetModuleAttr
-        self.check_getmoduleattr(getmoduleattr)
+    def test_importmoduleattr(self):
+        # Test PyImport_ImportModuleAttr()
+        importmoduleattr = _testcapi.PyImport_ImportModuleAttr
+        self.check_importmoduleattr(importmoduleattr)
 
         # Invalid module name type
         for mod_name in (object(), 123, b'bytes'):
             with self.subTest(mod_name=mod_name):
                 with self.assertRaises(TypeError):
-                    getmoduleattr(mod_name, "attr")
+                    importmoduleattr(mod_name, "attr")
 
         # Invalid attribute name type
         for attr_name in (object(), 123, b'bytes'):
             with self.subTest(attr_name=attr_name):
                 with self.assertRaises(TypeError):
-                    getmoduleattr("sys", attr_name)
+                    importmoduleattr("sys", attr_name)
 
         with self.assertRaises(SystemError):
-            getmoduleattr(NULL, "argv")
-        # CRASHES getmoduleattr("sys", NULL)
+            importmoduleattr(NULL, "argv")
+        # CRASHES importmoduleattr("sys", NULL)
 
-    def test_getmoduleattrstring(self):
-        # Test PyImport_GetModuleAttrString()
-        getmoduleattr = _testcapi.PyImport_GetModuleAttrString
-        self.check_getmoduleattr(getmoduleattr)
+    def test_importmoduleattrstring(self):
+        # Test PyImport_ImportModuleAttrString()
+        importmoduleattr = _testcapi.PyImport_ImportModuleAttrString
+        self.check_importmoduleattr(importmoduleattr)
 
         with self.assertRaises(UnicodeDecodeError):
-            getmoduleattr(b"sys\xff", "argv")
+            importmoduleattr(b"sys\xff", "argv")
         with self.assertRaises(UnicodeDecodeError):
-            getmoduleattr("sys", b"argv\xff")
+            importmoduleattr("sys", b"argv\xff")
 
-        # CRASHES getmoduleattr(NULL, "argv")
-        # CRASHES getmoduleattr("sys", NULL)
+        # CRASHES importmoduleattr(NULL, "argv")
+        # CRASHES importmoduleattr("sys", NULL)
 
     # TODO: test PyImport_GetImporter()
     # TODO: test PyImport_ReloadModule()

Misc/NEWS.d/next/C_API/2025-01-16-12-47-01.gh-issue-128911.mHVJ4x.rst

@@ -1,3 +1,3 @@
-Add :c:func:`PyImport_GetModuleAttr` and :c:func:`PyImport_GetModuleAttrString`
+Add :c:func:`PyImport_ImportModuleAttr` and :c:func:`PyImport_ImportModuleAttrString`
 helper functions to import a module and get an attribute of the module. Patch
 by Victor Stinner.

Modules/_ctypes/callbacks.c

@@ -492,7 +492,7 @@ long Call_GetClassObject(REFCLSID rclsid, REFIID riid, LPVOID *ppv)
     if (context == NULL)
         context = PyUnicode_InternFromString("_ctypes.DllGetClassObject");
 
-    func = PyImport_GetModuleAttrString("ctypes", "DllGetClassObject");
+    func = PyImport_ImportModuleAttrString("ctypes", "DllGetClassObject");
     if (!func) {
         PyErr_WriteUnraisable(context ? context : Py_None);
         /* There has been a warning before about this already */

Modules/_ctypes/stgdict.c

@@ -257,7 +257,7 @@ PyCStructUnionType_update_stginfo(PyObject *type, PyObject *fields, int isStruct
         goto error;
     }
 
-    PyObject *layout_func = PyImport_GetModuleAttrString("ctypes._layout",
+    PyObject *layout_func = PyImport_ImportModuleAttrString("ctypes._layout",
                                                           "get_layout");
     if (!layout_func) {
         goto error;

Modules/_cursesmodule.c

@@ -226,7 +226,7 @@ _PyCursesCheckFunction(int called, const char *funcname)
     if (called == TRUE) {
         return 1;
     }
-    PyObject *exc = PyImport_GetModuleAttrString("_curses", "error");
+    PyObject *exc = PyImport_ImportModuleAttrString("_curses", "error");
     if (exc != NULL) {
         PyErr_Format(exc, "must call %s() first", funcname);
         Py_DECREF(exc);

Modules/_datetimemodule.c

@@ -1839,7 +1839,7 @@ wrap_strftime(PyObject *object, PyObject *format, PyObject *timetuple,
     assert(object && format && timetuple);
     assert(PyUnicode_Check(format));
 
-    PyObject *strftime = PyImport_GetModuleAttrString("time", "strftime");
+    PyObject *strftime = PyImport_ImportModuleAttrString("time", "strftime");
     if (strftime == NULL) {
         return NULL;
     }
@@ -2021,7 +2021,7 @@ static PyObject *
 time_time(void)
 {
     PyObject *result = NULL;
-    PyObject *time = PyImport_GetModuleAttrString("time", "time");
+    PyObject *time = PyImport_ImportModuleAttrString("time", "time");
 
     if (time != NULL) {
         result = PyObject_CallNoArgs(time);
@@ -2039,7 +2039,7 @@ build_struct_time(int y, int m, int d, int hh, int mm, int ss, int dstflag)
     PyObject *struct_time;
     PyObject *result;
 
-    struct_time = PyImport_GetModuleAttrString("time", "struct_time");
+    struct_time = PyImport_ImportModuleAttrString("time", "struct_time");
     if (struct_time == NULL) {
         return NULL;
     }