explicitly raise PyErr_FormatUnraisable in tp_clear

picnixz · picnixz · commit 23a966428b60 · 2025-09-02T12:20:29.000+02:00
diff --git a/Modules/_curses_panel.c b/Modules/_curses_panel.c
@@ -438,8 +438,7 @@ PyCursesPanel_Clear(PyObject *op)
         Py_CLEAR(extra);
         if (set_panel_userptr(self->pan, NULL) == ERR) {
             curses_panel_panel_set_error(self, "set_panel_userptr", NULL);
-            // Do not add a PyErr_FormatUnraisable() because the GC
-            // is responsible for handling exceptions in tp_clear.
+            PyErr_FormatUnraisable("Exception ignored in tp_clear of %s", op);
         }
     }
     // do NOT clear self->wo yet as there is no cycle to break with it

Original file line number	Diff line number	Diff line change
`@@ -438,8 +438,7 @@ PyCursesPanel_Clear(PyObject *op)`
`438`	`438`	`Py_CLEAR(extra);`
`439`	`439`	`if (set_panel_userptr(self->pan, NULL) == ERR) {`
`440`	`440`	`curses_panel_panel_set_error(self, "set_panel_userptr", NULL);`
`441`		`- // Do not add a PyErr_FormatUnraisable() because the GC`
`442`		`- // is responsible for handling exceptions in tp_clear.`
	`441`	`+ PyErr_FormatUnraisable("Exception ignored in tp_clear of %s", op);`
`443`	`442`	`}`
`444`	`443`	`}`
`445`	`444`	`// do NOT clear self->wo yet as there is no cycle to break with it`