Skip to content

Commit 23e1444

Browse files
committed
Use static inline functions
Add _PyBytesWriter_GetSize() and _PyBytesWriter_GetData() static inline functions.
1 parent 9db9dc1 commit 23e1444

File tree

3 files changed

+26
-14
lines changed

3 files changed

+26
-14
lines changed

Include/internal/pycore_bytesobject.h

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,26 @@ struct PyBytesWriter {
7373
// Export for '_testcapi' shared extension
7474
PyAPI_FUNC(PyBytesWriter*) _PyBytesWriter_CreateByteArray(Py_ssize_t size);
7575

76+
static inline Py_ssize_t
77+
_PyBytesWriter_GetSize(PyBytesWriter *writer)
78+
{
79+
return writer->size;
80+
}
81+
82+
static inline char*
83+
_PyBytesWriter_GetData(PyBytesWriter *writer)
84+
{
85+
if (writer->obj == NULL) {
86+
return writer->small_buffer;
87+
}
88+
else if (writer->use_bytearray) {
89+
return PyByteArray_AS_STRING(writer->obj);
90+
}
91+
else {
92+
return PyBytes_AS_STRING(writer->obj);
93+
}
94+
}
95+
7696
#ifdef __cplusplus
7797
}
7898
#endif

Objects/bytesobject.c

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3480,15 +3480,7 @@ _PyBytes_Repeat(char* dest, Py_ssize_t len_dest,
34803480
static inline char*
34813481
byteswriter_data(PyBytesWriter *writer)
34823482
{
3483-
if (writer->obj == NULL) {
3484-
return writer->small_buffer;
3485-
}
3486-
else if (writer->use_bytearray) {
3487-
return PyByteArray_AS_STRING(writer->obj);
3488-
}
3489-
else {
3490-
return PyBytes_AS_STRING(writer->obj);
3491-
}
3483+
return _PyBytesWriter_GetData(writer);
34923484
}
34933485

34943486

@@ -3710,7 +3702,7 @@ PyBytesWriter_GetData(PyBytesWriter *writer)
37103702
Py_ssize_t
37113703
PyBytesWriter_GetSize(PyBytesWriter *writer)
37123704
{
3713-
return writer->size;
3705+
return _PyBytesWriter_GetSize(writer);
37143706
}
37153707

37163708

Objects/unicodeobject.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8867,7 +8867,7 @@ charmapencode_output(Py_UCS4 c, PyObject *mapping,
88678867
PyObject *rep;
88688868
unsigned char replace;
88698869
char *outstart;
8870-
Py_ssize_t outsize = PyBytesWriter_GetSize(writer);
8870+
Py_ssize_t outsize = _PyBytesWriter_GetSize(writer);
88718871

88728872
if (Py_IS_TYPE(mapping, &EncodingMapType)) {
88738873
int res = encoding_map_lookup(c, mapping);
@@ -8877,7 +8877,7 @@ charmapencode_output(Py_UCS4 c, PyObject *mapping,
88778877
if (outsize<requiredsize)
88788878
if (charmapencode_resize(writer, outpos, requiredsize))
88798879
return enc_EXCEPTION;
8880-
outstart = PyBytesWriter_GetData(writer);
8880+
outstart = _PyBytesWriter_GetData(writer);
88818881
outstart[(*outpos)++] = (char)res;
88828882
return enc_SUCCESS;
88838883
}
@@ -8896,7 +8896,7 @@ charmapencode_output(Py_UCS4 c, PyObject *mapping,
88968896
Py_DECREF(rep);
88978897
return enc_EXCEPTION;
88988898
}
8899-
outstart = PyBytesWriter_GetData(writer);
8899+
outstart = _PyBytesWriter_GetData(writer);
89008900
outstart[(*outpos)++] = (char)replace;
89018901
}
89028902
else {
@@ -8908,7 +8908,7 @@ charmapencode_output(Py_UCS4 c, PyObject *mapping,
89088908
Py_DECREF(rep);
89098909
return enc_EXCEPTION;
89108910
}
8911-
outstart = PyBytesWriter_GetData(writer);
8911+
outstart = _PyBytesWriter_GetData(writer);
89128912
memcpy(outstart + *outpos, repchars, repsize);
89138913
*outpos += repsize;
89148914
}

0 commit comments

Comments
 (0)