Add non-NULL check

neonene · web-flow · commit 263bdb2f94e3 · 2025-07-02T03:42:16.000+09:00
diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c
@@ -1621,10 +1621,12 @@ finalize_remove_modules(PyObject *modules, int verbose)
         }
     }
 
-    if (PyList_Extend(weaklist, weak_ext) < 0) {
-        PyErr_FormatUnraisable("Exception ignored while removing modules");
+    if (weaklist != NULL) {
+        if (PyList_Extend(weaklist, weak_ext) < 0) {
+            PyErr_FormatUnraisable("Exception ignored while removing modules");
+        }
+        Py_DECREF(weak_ext);
     }
-    Py_DECREF(weak_ext);
 
 #undef CLEAR_MODULE
 #undef STORE_MODULE_WEAKREF

Original file line number	Diff line number	Diff line change
`@@ -1621,10 +1621,12 @@ finalize_remove_modules(PyObject *modules, int verbose)`
`1621`	`1621`	`}`
`1622`	`1622`	`}`
`1623`	`1623`
`1624`		`- if (PyList_Extend(weaklist, weak_ext) < 0) {`
`1625`		`- PyErr_FormatUnraisable("Exception ignored while removing modules");`
	`1624`	`+ if (weaklist != NULL) {`
	`1625`	`+ if (PyList_Extend(weaklist, weak_ext) < 0) {`
	`1626`	`+ PyErr_FormatUnraisable("Exception ignored while removing modules");`
	`1627`	`+ }`
	`1628`	`+ Py_DECREF(weak_ext);`
`1626`	`1629`	`}`
`1627`		`- Py_DECREF(weak_ext);`
`1628`	`1630`
`1629`	`1631`	`#undef CLEAR_MODULE`
`1630`	`1632`	`#undef STORE_MODULE_WEAKREF`