Apply suggestions from code review

Author: YvesDup

Lib/test/lock_tests.py

@@ -371,16 +371,22 @@ def test_locked(self):
         self.assertFalse(lock.locked())
 
     def test_locked_2threads(self):
+        # see gh-134323: check that a rlock which
+        # is acquired in a secaondary thread,
+        # is still locked in the main thread.
         l = []
         rlock = self.locktype()
+        self.assertFalse(rlock.locked())
         def acquire():
+            l.append(rlock.locked())
             rlock.acquire()
             l.append(rlock.locked())
 
         with Bunch(acquire, 1):
             pass
         self.assertTrue(rlock.locked())
-        self.assertTrue(l[0])
+        self.assertFalse(l[0])
+        self.assertTrue(l[1])
         del rlock
 
     def test_release_save_unacquired(self):

Misc/NEWS.d/next/Library/2025-05-20-19-16-30.gh-issue-134323.ZQZGvw.rst

@@ -1,2 +1 @@
-Fix the public :meth:`locked<threading.RLock>` and its implementation in the ``_thread`` module.
-Also adding a unit test in ``lock_test.py`` file.
+Fix the :meth:`threading.RLock.locked` method.

Modules/_threadmodule.c

@@ -1022,6 +1022,13 @@ rlock_traverse(PyObject *self, visitproc visit, void *arg)
     return 0;
 }
 
+/*
+helper function used by rlock_locked and rlock_repr.
+*/
+static int
+rlock_locked_impl(rlockobject *self) {
+    return PyMutex_IsLocked(&self->lock.mutex);
+}
 
 static void
 rlock_dealloc(PyObject *self)
@@ -1114,8 +1121,8 @@ rlock_locked(PyObject *op, PyObject *Py_UNUSED(ignored))
     see gh-134323: the `_PyRecursiveMutex_IsLocked` function does not exist, so we cast the `op`
     to `lockobject` in order to call `PyMutex_IsLocked`.
     */
-    lockobject *self = lockobject_CAST(op);
-    int is_locked = PyMutex_IsLocked(&self->lock);
+    rlockobject *self = rlockobject_CAST(op);
+    int is_locked = rlock_locked_impl(self);
     return PyBool_FromLong(is_locked);
 }