Fix reference leak on buffer overflow

vstinner · vstinner · commit 2ae9abbb430f · 2025-05-27T12:05:59.000+02:00
diff --git a/Modules/fcntlmodule.c b/Modules/fcntlmodule.c
@@ -136,6 +136,7 @@ fcntl_fcntl_impl(PyObject *module, int fd, int code, PyObject *arg)
             }
             if (ptr[len] != '\0') {
                 PyErr_SetString(PyExc_SystemError, "buffer overflow");
+                Py_DECREF(result);
                 return NULL;
             }
             return result;
@@ -318,6 +319,7 @@ fcntl_ioctl_impl(PyObject *module, int fd, unsigned long code, PyObject *arg,
             }
             if (ptr[len] != '\0') {
                 PyErr_SetString(PyExc_SystemError, "buffer overflow");
+                Py_DECREF(result);
                 return NULL;
             }
             return result;

Original file line number	Diff line number	Diff line change
`@@ -136,6 +136,7 @@ fcntl_fcntl_impl(PyObject module, int fd, int code, PyObject arg)`
`136`	`136`	`}`
`137`	`137`	`if (ptr[len] != '\0') {`
`138`	`138`	`PyErr_SetString(PyExc_SystemError, "buffer overflow");`
	`139`	`+ Py_DECREF(result);`
`139`	`140`	`return NULL;`
`140`	`141`	`}`
`141`	`142`	`return result;`
`@@ -318,6 +319,7 @@ fcntl_ioctl_impl(PyObject module, int fd, unsigned long code, PyObject arg,`
`318`	`319`	`}`
`319`	`320`	`if (ptr[len] != '\0') {`
`320`	`321`	`PyErr_SetString(PyExc_SystemError, "buffer overflow");`
	`322`	`+ Py_DECREF(result);`
`321`	`323`	`return NULL;`
`322`	`324`	`}`
`323`	`325`	`return result;`