Skip to content

Commit 2b48c12

Browse files
fixup! gh-138122: Allow to filter by thread in tachyon's flamegraph (#139216)
1 parent 581828d commit 2b48c12

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

Lib/profiling/sampling/gecko_format.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -335,9 +335,6 @@ def add_sample(self, frames_list, timestamp, thread_id=0):
335335
def _get_frame_category(self, frame):
336336
"""
337337
Determine frame category based on frame information.
338-
Frame is a tuple: (filename, lineno, funcname)
339-
Can be extended to use any part of the frame for categorization.
340-
341338
TODO: Change this once frames have a type/category field
342339
"""
343340
filename, _, _ = frame

Lib/profiling/sampling/stack_collector.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -292,17 +292,6 @@ def _create_flamegraph_html(self, data):
292292
return html_content
293293

294294

295-
# Simple category configuration for Gecko profiles
296-
# TODO: This simple categorization should be enhanced once each frame includes category information
297-
# from the collector. Currently we only detect Python files by .py extension.
298-
PYTHON_CATEGORY = 0
299-
OTHER_CATEGORY = 1
300-
301-
GECKO_CATEGORIES = [
302-
{"name": "Python", "color": "blue", "subcategories": ["Other"]},
303-
{"name": "Other", "color": "grey", "subcategories": ["Other"]},
304-
]
305-
306295

307296
class GeckoCollector(StackTraceCollector):
308297
"""Collector that exports profiling data in Gecko Profile format for web-based profilers."""

0 commit comments

Comments
 (0)