Skip to content

Commit 2ef001b

Browse files
committed
Deal with test_configure_width and test_configure_height for Notebooks.
1 parent ec56443 commit 2ef001b

File tree

3 files changed

+12
-13
lines changed

3 files changed

+12
-13
lines changed

Lib/test/test_tkinter/test_widgets.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1556,13 +1556,13 @@ def test_configure_aspect(self):
15561556

15571557
def test_configure_padx(self):
15581558
widget = self.create()
1559-
self.checkPixelsParam(widget, 'padx', 3, 4.4, 5.6, '12m')#,
1559+
self.checkPixelsParam(widget, 'padx', 3, 4.4, 5.6, '12m')
15601560
expected = -2 if tk_version < (9, 0) else self._default_pixels
15611561
self.checkParam(widget, 'padx', -2, expected=expected)
15621562

15631563
def test_configure_pady(self):
15641564
widget = self.create()
1565-
self.checkPixelsParam(widget, 'pady', 3, 4.4, 5.6, '12m')#,
1565+
self.checkPixelsParam(widget, 'pady', 3, 4.4, 5.6, '12m')
15661566
expected = -2 if tk_version < (9, 0) else self._default_pixels
15671567
self.checkParam(widget, 'pady', -2, expected=expected)
15681568

Lib/test/test_tkinter/widget_tests.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,12 +145,14 @@ def checkEnumParam(self, widget, name, *values,
145145
def checkPixelsParam(self, widget, name, *values, conv=None, **kwargs):
146146
if not self._rounds_pixels or name in self._no_round:
147147
conv = False
148-
else:
148+
elif conv != str:
149149
conv = round
150150
for value in values:
151151
expected = _sentinel
152152
conv1 = conv
153153
if isinstance(value, str):
154+
if not getattr(self, '_converts_pixels', True):
155+
conv1 = str
154156
if conv1 and conv1 is not str:
155157
expected = pixels_conv(value) * self.scaling
156158
conv1 = round

Lib/test/test_ttk/test_widgets.py

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -994,6 +994,7 @@ class NotebookTest(AbstractWidgetTest, unittest.TestCase):
994994
'class', 'cursor', 'height', 'padding', 'style', 'takefocus', 'width',
995995
)
996996
_rounds_pixels = (tk_version < (9,0))
997+
_converts_pixels = False
997998
_clipped = {}
998999

9991000
def setUp(self):
@@ -1009,17 +1010,11 @@ def create(self, **kwargs):
10091010

10101011
def test_configure_height(self):
10111012
widget = self.create()
1012-
if tk_version < (9,0):
1013-
self.checkIntegerParam(widget, 'height', 402, -402, 0)
1014-
else:
1015-
self.checkPixelsParam(widget, 'height', 402, -402, 0)
1013+
self.checkPixelsParam(widget, 'height', '10c', 402, -402, 0)
10161014

10171015
def test_configure_width(self):
10181016
widget = self.create()
1019-
if tk_version < (9,0):
1020-
self.checkIntegerParam(widget, 'width', 402, -402, 0)
1021-
else:
1022-
self.checkPixelsParam(widget, 'width', 402, -402, 0)
1017+
self.checkPixelsParam(widget, 'width', '10c', 402, -402, 0)
10231018

10241019
def test_tab_identifiers(self):
10251020
self.nb.forget(0)
@@ -1445,8 +1440,10 @@ def test_configure_displaycolumns(self):
14451440

14461441
def test_configure_height(self):
14471442
widget = self.create()
1448-
self.checkPixelsParam(widget, 'height', 100, -100, 0, '3c', conv=False)
1449-
self.checkPixelsParam(widget, 'height', 101.2, 102.6, conv=False)
1443+
self.checkPixelsParam(widget, 'height', 100, -100, 0, '3c',
1444+
conv=False)
1445+
self.checkPixelsParam(widget, 'height', 101.2, 102.6, '3c',
1446+
conv=False)
14501447

14511448
def test_configure_selectmode(self):
14521449
widget = self.create()

0 commit comments

Comments
 (0)