alyssa review

Author: hauntsaninja

Doc/whatsnew/3.13.rst

@@ -274,7 +274,7 @@ Improved error messages
        File "/home/me/random.py", line 3, in <module>
          print(random.randint(5))
                ^^^^^^^^^^^^^^
-     AttributeError: module 'random' has no attribute 'randint' (consider renaming '/home/me/random.py' since it has the same name as the standard library module named 'random' and the import system gives it precedence)
+     AttributeError: module 'random' has no attribute 'randint' (consider renaming '/home/me/random.py' since it has the same name as the standard library module named 'random' and prevents importing that standard library module)
 
   Similarly, if a script has the same name as a third-party
   module that it attempts to import and this results in errors,

Lib/test/test_import/__init__.py

@@ -822,7 +822,7 @@ def test_script_shadowing_stdlib(self):
                 expected_error = error + (
                     rb" \(consider renaming '.*fractions.py' since it has the "
                     rb"same name as the standard library module named 'fractions' "
-                    rb"and the import system gives it precedence\)"
+                    rb"and prevents importing that standard library module\)"
                 )
 
                 popen = script_helper.spawn_python(os.path.join(tmp, "fractions.py"), cwd=tmp)
@@ -883,7 +883,7 @@ def test_package_shadowing_stdlib_module(self):
                 expected_error = error + (
                     rb" \(consider renaming '.*[\\/]fractions[\\/]+__init__.py' since it has the "
                     rb"same name as the standard library module named 'fractions' "
-                    rb"and the import system gives it precedence\)"
+                    rb"and prevents importing that standard library module\)"
                 )
 
                 popen = script_helper.spawn_python(os.path.join(tmp, "main.py"), cwd=tmp)
@@ -1122,7 +1122,7 @@ def test_script_shadowing_stdlib_sys_path_modification(self):
                 expected_error = error + (
                     rb" \(consider renaming '.*fractions.py' since it has the "
                     rb"same name as the standard library module named 'fractions' "
-                    rb"and the import system gives it precedence\)"
+                    rb"and prevents importing that standard library module\)"
                 )
 
                 popen = script_helper.spawn_python("main.py", cwd=tmp)

Objects/moduleobject.c

@@ -1017,7 +1017,7 @@ _Py_module_getattro_impl(PyModuleObject *m, PyObject *name, int suppress)
                     "module '%U' has no attribute '%U' "
                     "(consider renaming '%U' since it has the same "
                     "name as the standard library module named '%U' "
-                    "and the import system gives it precedence)",
+                    "and prevents importing that standard library module)",
                     mod_name, name, origin, mod_name);
     }
     else {

Python/ceval.c

@@ -2873,7 +2873,7 @@ _PyEval_ImportFrom(PyThreadState *tstate, PyObject *v, PyObject *name)
             "cannot import name %R from %R "
             "(consider renaming %R since it has the same "
             "name as the standard library module named %R "
-            "and the import system gives it precedence)",
+            "and prevents importing that standard library module)",
             name, mod_name_or_unknown, origin, mod_name_or_unknown
         );
     }