gh-120244: Fix re.sub() reference leak (GH-120245)

neonene · web-flow · commit 38a25e9560cf · 2024-06-08T10:22:07.000Z
diff --git a/Misc/NEWS.d/next/Library/2024-06-08-09-45-31.gh-issue-120244.8o9Dzr.rst b/Misc/NEWS.d/next/Library/2024-06-08-09-45-31.gh-issue-120244.8o9Dzr.rst
@@ -0,0 +1 @@
+Fix memory leak in :func:`re.sub()` when the replacement string contains backreferences.
diff --git a/Modules/_sre/sre.c b/Modules/_sre/sre.c
@@ -1622,6 +1622,7 @@ _sre_template_impl(PyObject *module, PyObject *pattern, PyObject *template)
         }
         self->items[i].literal = Py_XNewRef(literal);
     }
+    PyObject_GC_Track(self);
     return (PyObject*) self;
 
 bad_template:

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix memory leak in :func:`re.sub()` when the replacement string contains backreferences.
Original file line number	Diff line number	Diff line change
`@@ -1622,6 +1622,7 @@ _sre_template_impl(PyObject module, PyObject pattern, PyObject *template)`
`1622`	`1622`	`}`
`1623`	`1623`	`self->items[i].literal = Py_XNewRef(literal);`
`1624`	`1624`	`}`
	`1625`	`+ PyObject_GC_Track(self);`
`1625`	`1626`	`return (PyObject*) self;`
`1626`	`1627`
`1627`	`1628`	`bad_template:`