Skip to content

Commit 39bee16

Browse files
committed
leave assertions commented out
1 parent bf15e93 commit 39bee16

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

Include/cpython/pyatomic.h

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -550,10 +550,12 @@ _Py_atomic_load_ssize_acquire(const Py_ssize_t *obj);
550550
static inline void *
551551
_Py_atomic_memcpy_ptr_store_relaxed(void *dest, void *src, size_t n)
552552
{
553-
assert(1 == 1);
554-
// assert(((uintptr_t)dest & (sizeof (void *) - 1)) == 0);
555-
// assert(((uintptr_t)src & (sizeof (void *) - 1)) == 0);
556-
// assert(n % sizeof(void *) == 0);
553+
// XXX: The assertions below currently fail on Android ARM build.
554+
// In fact, assert(1 == 1) fails on that build.
555+
556+
// assert(((uintptr_t)dest & (uintptr_t)(sizeof (void *) - 1)) == 0);
557+
// assert(((uintptr_t)src & (uintptr_t)(sizeof (void *) - 1)) == 0);
558+
// assert(n % (size_t)sizeof(void *) == 0);
557559

558560
if (dest != src) {
559561
void **dest_ = (void **)dest;
@@ -571,9 +573,9 @@ _Py_atomic_memcpy_ptr_store_relaxed(void *dest, void *src, size_t n)
571573
static inline void *
572574
_Py_atomic_memmove_ptr_store_relaxed(void *dest, void *src, size_t n)
573575
{
574-
// assert(((uintptr_t)dest & (sizeof (void *) - 1)) == 0);
575-
// assert(((uintptr_t)src & (sizeof (void *) - 1)) == 0);
576-
// assert(n % sizeof(void *) == 0);
576+
// assert(((uintptr_t)dest & (uintptr_t)(sizeof (void *) - 1)) == 0);
577+
// assert(((uintptr_t)src & (uintptr_t)(sizeof (void *) - 1)) == 0);
578+
// assert(n % (size_t)sizeof(void *) == 0);
577579

578580
if (dest < src || dest >= (void *)((char *)src + n)) {
579581
void **dest_ = (void **)dest;

0 commit comments

Comments
 (0)