Skip to content

Commit 3a04be9

Browse files
authored
gh-76760: test that uuid.uuid1() sets the version field (#139033)
1 parent 2fc7004 commit 3a04be9

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

Lib/test/test_uuid.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -590,6 +590,7 @@ def test_uuid1_safe(self):
590590
# dependent on the underlying platform support. At least it cannot be
591591
# unknown (unless I suppose the platform is buggy).
592592
self.assertNotEqual(u.is_safe, self.uuid.SafeUUID.unknown)
593+
self.assertEqual(u.version, 1)
593594

594595
@contextlib.contextmanager
595596
def mock_generate_time_safe(self, safe_value):
@@ -612,24 +613,28 @@ def test_uuid1_unknown(self):
612613
with self.mock_generate_time_safe(None):
613614
u = self.uuid.uuid1()
614615
self.assertEqual(u.is_safe, self.uuid.SafeUUID.unknown)
616+
self.assertEqual(u.version, 1)
615617

616618
@unittest.skipUnless(os.name == 'posix', 'POSIX-only test')
617619
def test_uuid1_is_safe(self):
618620
with self.mock_generate_time_safe(0):
619621
u = self.uuid.uuid1()
620622
self.assertEqual(u.is_safe, self.uuid.SafeUUID.safe)
623+
self.assertEqual(u.version, 1)
621624

622625
@unittest.skipUnless(os.name == 'posix', 'POSIX-only test')
623626
def test_uuid1_is_unsafe(self):
624627
with self.mock_generate_time_safe(-1):
625628
u = self.uuid.uuid1()
626629
self.assertEqual(u.is_safe, self.uuid.SafeUUID.unsafe)
630+
self.assertEqual(u.version, 1)
627631

628632
@unittest.skipUnless(os.name == 'posix', 'POSIX-only test')
629633
def test_uuid1_bogus_return_value(self):
630634
with self.mock_generate_time_safe(3):
631635
u = self.uuid.uuid1()
632636
self.assertEqual(u.is_safe, self.uuid.SafeUUID.unknown)
637+
self.assertEqual(u.version, 1)
633638

634639
def test_uuid1_time(self):
635640
with mock.patch.object(self.uuid, '_generate_time_safe', None), \

Lib/uuid.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -737,6 +737,7 @@ def uuid1(node=None, clock_seq=None):
737737
is_safe = SafeUUID(safely_generated)
738738
except ValueError:
739739
is_safe = SafeUUID.unknown
740+
# The version field is assumed to be handled by _generate_time_safe().
740741
return UUID(bytes=uuid_time, is_safe=is_safe)
741742

742743
global _last_timestamp

0 commit comments

Comments
 (0)