Apply code review suggestions from Tomas

Fidget-Spinner · Fidget-Spinner · commit 4d9a68e257ec · 2025-06-04T22:22:00.000+08:00
diff --git a/Include/internal/pycore_optimizer.h b/Include/internal/pycore_optimizer.h
@@ -238,18 +238,18 @@ PyJitRef_AsSymbolBorrow(JitOptRef ref)
 bool _Py_uop_sym_is_immortal(JitOptSymbol *sym);
 
 static inline JitOptRef
-PyJitRef_FromSymbolSteal(JitOptSymbol *sym)
+PyJitRef_FromSymbolBorrow(JitOptSymbol *sym)
 {
-    if (sym == NULL || _Py_uop_sym_is_immortal(sym)) {
-        return (JitOptRef){.bits=(uintptr_t)sym | Py_TAG_REFCNT};
-    }
-    return (JitOptRef){.bits=(uintptr_t)sym};
+    return (JitOptRef){.bits=(uintptr_t)sym | Py_TAG_REFCNT};
 }
 
 static inline JitOptRef
-PyJitRef_FromSymbolBorrow(JitOptSymbol *sym)
+PyJitRef_FromSymbolSteal(JitOptSymbol *sym)
 {
-    return (JitOptRef){.bits=(uintptr_t)sym | Py_TAG_REFCNT};
+    if (sym == NULL || _Py_uop_sym_is_immortal(sym)) {
+        return PyJitRef_FromSymbolBorrow(sym);
+    }
+    return (JitOptRef){.bits=(uintptr_t)sym};
 }
 
 static inline JitOptRef

Original file line number	Diff line number	Diff line change
`@@ -238,18 +238,18 @@ PyJitRef_AsSymbolBorrow(JitOptRef ref)`
`238`	`238`	`bool _Py_uop_sym_is_immortal(JitOptSymbol *sym);`
`239`	`239`
`240`	`240`	`static inline JitOptRef`
`241`		`-PyJitRef_FromSymbolSteal(JitOptSymbol *sym)`
	`241`	`+PyJitRef_FromSymbolBorrow(JitOptSymbol *sym)`
`242`	`242`	`{`
`243`		`- if (sym == NULL \|\| _Py_uop_sym_is_immortal(sym)) {`
`244`		`- return (JitOptRef){.bits=(uintptr_t)sym \| Py_TAG_REFCNT};`
`245`		`- }`
`246`		`- return (JitOptRef){.bits=(uintptr_t)sym};`
	`243`	`+ return (JitOptRef){.bits=(uintptr_t)sym \| Py_TAG_REFCNT};`
`247`	`244`	`}`
`248`	`245`
`249`	`246`	`static inline JitOptRef`
`250`		`-PyJitRef_FromSymbolBorrow(JitOptSymbol *sym)`
	`247`	`+PyJitRef_FromSymbolSteal(JitOptSymbol *sym)`
`251`	`248`	`{`
`252`		`- return (JitOptRef){.bits=(uintptr_t)sym \| Py_TAG_REFCNT};`
	`249`	`+ if (sym == NULL \|\| _Py_uop_sym_is_immortal(sym)) {`
	`250`	`+ return PyJitRef_FromSymbolBorrow(sym);`
	`251`	`+ }`
	`252`	`+ return (JitOptRef){.bits=(uintptr_t)sym};`
`253`	`253`	`}`
`254`	`254`
`255`	`255`	`static inline JitOptRef`