Review (part 3): add more tests

Author: AA-Turner

Lib/test/test_clinic.py

@@ -4088,6 +4088,49 @@ def test_depr_multi(self):
         check("a", b="b", c="c", d="d", e="e", f="f", g="g")
         self.assertRaises(TypeError, fn, a="a", b="b", c="c", d="d", e="e", f="f", g="g")
 
+    def test_lone_kwds(self):
+        with self.assertRaises(TypeError):
+            ac_tester.lone_kwds(1, 2)
+        self.assertEqual(ac_tester.lone_kwds(), ({},))
+        self.assertEqual(ac_tester.lone_kwds(y='y'), ({'y': 'y'},))
+        kwds = {'y': 'y', 'z': 'z'}
+        self.assertEqual(ac_tester.lone_kwds(y='y', z='z'), (kwds,))
+        self.assertEqual(ac_tester.lone_kwds(**kwds), (kwds,))
+
+    def test_kwds_with_pos_only(self):
+        with self.assertRaises(TypeError):
+            ac_tester.kwds_with_pos_only()
+        with self.assertRaises(TypeError):
+            ac_tester.kwds_with_pos_only(y='y')
+        with self.assertRaises(TypeError):
+            ac_tester.kwds_with_pos_only(1, y='y')
+        self.assertEqual(ac_tester.kwds_with_pos_only(1, 2), (1, 2, {}))
+        self.assertEqual(ac_tester.kwds_with_pos_only(1, 2, y='y'), (1, 2, {'y': 'y'}))
+        kwds = {'y': 'y', 'z': 'z'}
+        self.assertEqual(ac_tester.kwds_with_pos_only(1, 2, y='y', z='z'), (1, 2, kwds))
+        self.assertEqual(ac_tester.kwds_with_pos_only(1, 2, **kwds), (1, 2, kwds))
+
+    def test_kwds_with_stararg(self):
+        self.assertEqual(ac_tester.kwds_with_stararg(), ((), {}))
+        self.assertEqual(ac_tester.kwds_with_stararg(1, 2), ((1, 2), {}))
+        self.assertEqual(ac_tester.kwds_with_stararg(y='y'), ((), {'y': 'y'}))
+        args = (1, 2)
+        kwds = {'y': 'y', 'z': 'z'}
+        self.assertEqual(ac_tester.kwds_with_stararg(1, 2, y='y', z='z'), (args, kwds))
+        self.assertEqual(ac_tester.kwds_with_stararg(*args, **kwds), (args, kwds))
+
+    def test_kwds_with_pos_only_and_stararg(self):
+        with self.assertRaises(TypeError):
+            ac_tester.kwds_with_pos_only_and_stararg()
+        with self.assertRaises(TypeError):
+            ac_tester.kwds_with_pos_only_and_stararg(y='y')
+        self.assertEqual(ac_tester.kwds_with_pos_only_and_stararg(1, 2), (1, 2, (), {}))
+        self.assertEqual(ac_tester.kwds_with_pos_only_and_stararg(1, 2, y='y'), (1, 2, (), {'y': 'y'}))
+        args = ('lobster', 'thermidor')
+        kwds = {'y': 'y', 'z': 'z'}
+        self.assertEqual(ac_tester.kwds_with_pos_only_and_stararg(1, 2, 'lobster', 'thermidor', y='y', z='z'), (1, 2, args, kwds))
+        self.assertEqual(ac_tester.kwds_with_pos_only_and_stararg(1, 2, *args, **kwds), (1, 2, args, kwds))
+
 
 class LimitedCAPIOutputTests(unittest.TestCase):
 

Modules/_testclinic.c

@@ -2336,7 +2336,7 @@ static PyObject *
 lone_kwds_impl(PyObject *module, PyObject *kwds)
 /*[clinic end generated code: output=572549c687a0432e input=6ef338b913ecae17]*/
 {
-    Py_RETURN_NONE;
+    return pack_arguments_newref(1, kwds);
 }
 
 
@@ -2353,7 +2353,7 @@ kwds_with_pos_only_impl(PyObject *module, PyObject *a, PyObject *b,
                         PyObject *kwds)
 /*[clinic end generated code: output=573096d3a7efcce5 input=da081a5d9ae8878a]*/
 {
-    Py_RETURN_NONE;
+    return pack_arguments_newref(3, a, b, kwds);
 }
 
 
@@ -2367,7 +2367,7 @@ static PyObject *
 kwds_with_stararg_impl(PyObject *module, PyObject *args, PyObject *kwds)
 /*[clinic end generated code: output=d4b0064626a25208 input=1be404572d685859]*/
 {
-    Py_RETURN_NONE;
+    return pack_arguments_newref(2, args, kwds);
 }
 
 
@@ -2386,7 +2386,7 @@ kwds_with_pos_only_and_stararg_impl(PyObject *module, PyObject *a,
                                     PyObject *kwds)
 /*[clinic end generated code: output=af7df7640c792246 input=2fe330c7981f0829]*/
 {
-    Py_RETURN_NONE;
+    return pack_arguments_newref(4, a, b, args, kwds);
 }