Address review comments.

Author: serhiy-storchaka

Include/internal/pycore_bytes_methods.h

@@ -48,7 +48,7 @@ extern PyObject *_Py_bytes_endswith(const char *str, Py_ssize_t len,
 extern PyObject* _Py_bytes_maketrans(Py_buffer *frm, Py_buffer *to);
 
 /* Helper for repr(bytes) and repr(bytearray). */
-extern PyObject *_Py_bytes_repr(const char *, Py_ssize_t, int);
+extern PyObject *_Py_bytes_repr(const char *, Py_ssize_t, int, const char *);
 
 /* Shared __doc__ strings. */
 extern const char _Py_isspace__doc__[];

Objects/bytearrayobject.c

@@ -1073,12 +1073,9 @@ bytearray_repr_lock_held(PyObject *op)
     _Py_CRITICAL_SECTION_ASSERT_OBJECT_LOCKED(op);
     const char *className = _PyType_Name(Py_TYPE(op));
     PyObject *bytes_repr = _Py_bytes_repr(PyByteArray_AS_STRING(op),
-                                          PyByteArray_GET_SIZE(op), 1);
+                                          PyByteArray_GET_SIZE(op), 1,
+                                          "bytearray");
     if (bytes_repr == NULL) {
-        if (PyErr_ExceptionMatches(PyExc_OverflowError)) {
-            PyErr_SetString(PyExc_OverflowError,
-                "bytearray object is too large to make repr");
-        }
         return NULL;
     }
     PyObject *res = PyUnicode_FromFormat("%s(%U)", className, bytes_repr);

Objects/bytesobject.c

@@ -1340,11 +1340,12 @@ PyObject *
 PyBytes_Repr(PyObject *obj, int smartquotes)
 {
     return _Py_bytes_repr(PyBytes_AS_STRING(obj),
-                          PyBytes_GET_SIZE(obj), smartquotes);
+                          PyBytes_GET_SIZE(obj), smartquotes, "bytes");
 }
 
 PyObject *
-_Py_bytes_repr(const char *data, Py_ssize_t length, int smartquotes)
+_Py_bytes_repr(const char *data, Py_ssize_t length, int smartquotes,
+               const char *classname)
 {
     Py_ssize_t i;
     Py_ssize_t newsize, squotes, dquotes;
@@ -1411,8 +1412,8 @@ _Py_bytes_repr(const char *data, Py_ssize_t length, int smartquotes)
     return v;
 
   overflow:
-    PyErr_SetString(PyExc_OverflowError,
-                    "bytes object is too large to make repr");
+    PyErr_Format(PyExc_OverflowError,
+                 "%s object is too large to make repr", classname);
     return NULL;
 }