Skip to content

Commit 540a359

Browse files
Benedikt's suggestions
1 parent c3b759c commit 540a359

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

Lib/test/test_minidom.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -417,6 +417,7 @@ def testGetAttrValues(self):
417417
el.setAttribute("foo", "bar")
418418
values = [x.value for x in el.attributes.values()]
419419
self.assertIn("bar", values)
420+
self.assertIn("jam", values)
420421

421422
def testGetAttribute(self):
422423
dom = Document()
@@ -512,9 +513,9 @@ def testAttributeRepr(self):
512513

513514
def testTextNodeRepr(self):
514515
dom = Document()
515-
el = dom.appendChild(dom.createElement("foo"))
516-
self.assertEqual(str(el), repr(el))
517-
dom.unlink()
516+
self.addCleanup(dom.unlink)
517+
text = dom.createTextNode("monty")
518+
self.assertEqual(str(text), repr(text))
518519

519520
def testWriteXML(self):
520521
str = '<?xml version="1.0" ?><a b="c"/>'
@@ -626,10 +627,12 @@ def testProcessingInstructionRepr(self):
626627

627628
def testTextRepr(self):
628629
dom = Document()
629-
elem = dom.createElement('elem')
630+
self.addCleanup(dom.unlink)
631+
elem = dom.createElement("elem")
630632
elem.appendChild(dom.createTextNode("foo"))
631633
el = elem.firstChild
632634
self.assertEqual(str(el), repr(el))
635+
self.assertEqual('<DOM Text node "\'foo\'">', str(el))
633636

634637
def testWriteText(self): pass
635638

0 commit comments

Comments
 (0)