Skip to content

Commit 543b26a

Browse files
Address PR comments
1 parent 5bde46e commit 543b26a

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

Python/jit.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -473,19 +473,19 @@ _PyJIT_Compile(_PyExecutorObject *executor, const _PyUOpInstruction trace[], siz
473473
group = &shim;
474474
code_size += group->code_size;
475475
data_size += group->data_size;
476-
combine_symbol_mask(group->shim_mask, state.trampolines.mask);
476+
combine_symbol_mask(group->trampoline_mask, state.trampolines.mask);
477477
for (size_t i = 0; i < length; i++) {
478478
const _PyUOpInstruction *instruction = &trace[i];
479479
group = &stencil_groups[instruction->opcode];
480480
state.instruction_starts[i] = code_size;
481481
code_size += group->code_size;
482482
data_size += group->data_size;
483-
combine_symbol_mask(group->shim_mask, state.trampolines.mask);
483+
combine_symbol_mask(group->trampoline_mask, state.trampolines.mask);
484484
}
485485
group = &stencil_groups[_FATAL_ERROR];
486486
code_size += group->code_size;
487487
data_size += group->data_size;
488-
combine_symbol_mask(group->shim_mask, state.trampolines.mask);
488+
combine_symbol_mask(group->trampoline_mask, state.trampolines.mask);
489489
// Calculate the size of the trampolines required by the whole trace
490490
for (size_t i = 0; i < Py_ARRAY_LENGTH(state.trampolines.mask); i++) {
491491
state.trampolines.size += _Py_popcount32(state.trampolines.mask[i]) * TRAMPOLINE_SIZE;
@@ -509,9 +509,7 @@ _PyJIT_Compile(_PyExecutorObject *executor, const _PyUOpInstruction trace[], siz
509509
state.trampolines.mem = memory + code_size + data_size;
510510
// Compile the shim, which handles converting between the native
511511
// calling convention and the calling convention used by jitted code
512-
// (which may be different for efficiency reasons). On platforms where
513-
// we don't change calling conventions, the shim is empty and
514-
// nothing is emitted here:
512+
// (which may be different for efficiency reasons).
515513
group = &shim;
516514
group->emit(code, data, executor, NULL, &state);
517515
code += group->code_size;

Tools/jit/_writer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ def _dump_footer(
1919
yield " const _PyUOpInstruction *instruction, jit_state *state);"
2020
yield " size_t code_size;"
2121
yield " size_t data_size;"
22-
yield " symbol_mask shim_mask;"
22+
yield " symbol_mask trampoline_mask;"
2323
yield "} StencilGroup;"
2424
yield ""
2525
yield f"static const StencilGroup shim = {groups['shim'].as_c('shim')};"

0 commit comments

Comments
 (0)