Skip to content

Commit 596c220

Browse files
Merge branch 'main' into main
2 parents b4cd5c9 + 60181f4 commit 596c220

File tree

13 files changed

+148
-64
lines changed

13 files changed

+148
-64
lines changed

Doc/library/email.header.rst

Lines changed: 29 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -178,16 +178,36 @@ The :mod:`email.header` module also provides the following convenient functions.
178178
Decode a message header value without converting the character set. The header
179179
value is in *header*.
180180

181-
This function returns a list of ``(decoded_string, charset)`` pairs containing
182-
each of the decoded parts of the header. *charset* is ``None`` for non-encoded
183-
parts of the header, otherwise a lower case string containing the name of the
184-
character set specified in the encoded string.
181+
For historical reasons, this function may return either:
185182

186-
Here's an example::
183+
1. A list of pairs containing each of the decoded parts of the header,
184+
``(decoded_bytes, charset)``, where *decoded_bytes* is always an instance of
185+
:class:`bytes`, and *charset* is either:
186+
187+
- A lower case string containing the name of the character set specified.
188+
189+
- ``None`` for non-encoded parts of the header.
190+
191+
2. A list of length 1 containing a pair ``(string, None)``, where
192+
*string* is always an instance of :class:`str`.
193+
194+
An :exc:`email.errors.HeaderParseError` may be raised when certain decoding
195+
errors occur (e.g. a base64 decoding exception).
196+
197+
Here are examples:
187198

188199
>>> from email.header import decode_header
189200
>>> decode_header('=?iso-8859-1?q?p=F6stal?=')
190201
[(b'p\xf6stal', 'iso-8859-1')]
202+
>>> decode_header('unencoded_string')
203+
[('unencoded_string', None)]
204+
>>> decode_header('bar =?utf-8?B?ZsOzbw==?=')
205+
[(b'bar ', None), (b'f\xc3\xb3o', 'utf-8')]
206+
207+
.. note::
208+
209+
This function exists for for backwards compatibility only. For
210+
new code, we recommend using :class:`email.headerregistry.HeaderRegistry`.
191211

192212

193213
.. function:: make_header(decoded_seq, maxlinelen=None, header_name=None, continuation_ws=' ')
@@ -203,3 +223,7 @@ The :mod:`email.header` module also provides the following convenient functions.
203223
:class:`Header` instance. Optional *maxlinelen*, *header_name*, and
204224
*continuation_ws* are as in the :class:`Header` constructor.
205225

226+
.. note::
227+
228+
This function exists for for backwards compatibility only, and is
229+
not recommended for use in new code.

Doc/library/sys.rst

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1933,6 +1933,13 @@ always available. Unless explicitly noted otherwise, all variables are read-only
19331933
interpreter is pre-release (alpha, beta, or release candidate) then the
19341934
local and remote interpreters must be the same exact version.
19351935

1936+
.. audit-event:: remote_debugger_script script_path
1937+
1938+
When the script is executed in the remote process, an
1939+
:ref:`auditing event <auditing>`
1940+
``sys.remote_debugger_script`` is raised
1941+
with the path in the remote process.
1942+
19361943
.. availability:: Unix, Windows.
19371944
.. versionadded:: 3.14
19381945

Doc/whatsnew/3.14.rst

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1259,6 +1259,14 @@ concurrent.futures
12591259
buffer.
12601260
(Contributed by Enzo Bonnal and Josh Rosenberg in :gh:`74028`.)
12611261

1262+
configparser
1263+
------------
1264+
1265+
* Security fix: will no longer write config files it cannot read. Attempting
1266+
to :meth:`configparser.ConfigParser.write` keys containing delimiters or
1267+
beginning with the section header pattern will raise a
1268+
:class:`configparser.InvalidWriteError`.
1269+
(Contributed by Jacob Lincoln in :gh:`129270`)
12621270

12631271
contextvars
12641272
-----------

Lib/configparser.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1218,11 +1218,14 @@ def _convert_to_boolean(self, value):
12181218

12191219
def _validate_key_contents(self, key):
12201220
"""Raises an InvalidWriteError for any keys containing
1221-
delimiters or that match the section header pattern"""
1221+
delimiters or that begins with the section header pattern"""
12221222
if re.match(self.SECTCRE, key):
1223-
raise InvalidWriteError("Cannot write keys matching section pattern")
1224-
if any(delim in key for delim in self._delimiters):
1225-
raise InvalidWriteError("Cannot write key that contains delimiters")
1223+
raise InvalidWriteError(
1224+
f"Cannot write key {key}; begins with section pattern")
1225+
for delim in self._delimiters:
1226+
if delim in key:
1227+
raise InvalidWriteError(
1228+
f"Cannot write key {key}; contains delimiter {delim}")
12261229

12271230
def _validate_value_types(self, *, section="", option="", value=""):
12281231
"""Raises a TypeError for illegal non-string values.

Lib/email/header.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,16 +59,22 @@
5959
def decode_header(header):
6060
"""Decode a message header value without converting charset.
6161
62-
Returns a list of (string, charset) pairs containing each of the decoded
63-
parts of the header. Charset is None for non-encoded parts of the header,
64-
otherwise a lower-case string containing the name of the character set
65-
specified in the encoded string.
62+
For historical reasons, this function may return either:
63+
64+
1. A list of length 1 containing a pair (str, None).
65+
2. A list of (bytes, charset) pairs containing each of the decoded
66+
parts of the header. Charset is None for non-encoded parts of the header,
67+
otherwise a lower-case string containing the name of the character set
68+
specified in the encoded string.
6669
6770
header may be a string that may or may not contain RFC2047 encoded words,
6871
or it may be a Header object.
6972
7073
An email.errors.HeaderParseError may be raised when certain decoding error
7174
occurs (e.g. a base64 decoding exception).
75+
76+
This function exists for backwards compatibility only. For new code, we
77+
recommend using email.headerregistry.HeaderRegistry instead.
7278
"""
7379
# If it is a Header object, we can just return the encoded chunks.
7480
if hasattr(header, '_chunks'):
@@ -161,6 +167,9 @@ def make_header(decoded_seq, maxlinelen=None, header_name=None,
161167
This function takes one of those sequence of pairs and returns a Header
162168
instance. Optional maxlinelen, header_name, and continuation_ws are as in
163169
the Header constructor.
170+
171+
This function exists for backwards compatibility only, and is not
172+
recommended for use in new code.
164173
"""
165174
h = Header(maxlinelen=maxlinelen, header_name=header_name,
166175
continuation_ws=continuation_ws)

Lib/http/server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@
115115
class HTTPServer(socketserver.TCPServer):
116116

117117
allow_reuse_address = True # Seems to make sense in testing environment
118-
allow_reuse_port = True
118+
allow_reuse_port = False
119119

120120
def server_bind(self):
121121
"""Override server_bind to store the server name."""

Lib/logging/config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1018,7 +1018,7 @@ class ConfigSocketReceiver(ThreadingTCPServer):
10181018
"""
10191019

10201020
allow_reuse_address = True
1021-
allow_reuse_port = True
1021+
allow_reuse_port = False
10221022

10231023
def __init__(self, host='localhost', port=DEFAULT_LOGGING_CONFIG_PORT,
10241024
handler=None, ready=None, verify=None):

Lib/test/test_email/test_email.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2568,6 +2568,18 @@ def test_multiline_header(self):
25682568
self.assertEqual(str(make_header(decode_header(s))),
25692569
'"Müller T" <[email protected]>')
25702570

2571+
def test_unencoded_ascii(self):
2572+
# bpo-22833/gh-67022: returns [(str, None)] rather than [(bytes, None)]
2573+
s = 'header without encoded words'
2574+
self.assertEqual(decode_header(s),
2575+
[('header without encoded words', None)])
2576+
2577+
def test_unencoded_utf8(self):
2578+
# bpo-22833/gh-67022: returns [(str, None)] rather than [(bytes, None)]
2579+
s = 'header with unexpected non ASCII caract\xe8res'
2580+
self.assertEqual(decode_header(s),
2581+
[('header with unexpected non ASCII caract\xe8res', None)])
2582+
25712583

25722584
# Test the MIMEMessage class
25732585
class TestMIMEMessage(TestEmailBase):

Lib/test/test_logging.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1036,7 +1036,7 @@ class TestTCPServer(ControlMixin, ThreadingTCPServer):
10361036
"""
10371037

10381038
allow_reuse_address = True
1039-
allow_reuse_port = True
1039+
allow_reuse_port = False
10401040

10411041
def __init__(self, addr, handler, poll_interval=0.5,
10421042
bind_and_activate=True):

Lib/xmlrpc/server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -578,7 +578,7 @@ class SimpleXMLRPCServer(socketserver.TCPServer,
578578
"""
579579

580580
allow_reuse_address = True
581-
allow_reuse_port = True
581+
allow_reuse_port = False
582582

583583
# Warning: this is for debugging purposes only! Never set this to True in
584584
# production code, as will be sending out sensitive information (exception

0 commit comments

Comments
 (0)