Skip to content

Commit 5f3ec52

Browse files
Apply suggestions from code review
Co-authored-by: Brandt Bucher <[email protected]>
1 parent bb1e650 commit 5f3ec52

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

Tools/jit/_targets.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,9 @@ async def _compile(
135135
# Don't call stack-smashing canaries that we can't find or patch:
136136
"-fno-stack-protector",
137137
"-std=c11",
138+
"-o",
139+
f"{o}",
140+
f"{c}",
138141
*self.args,
139142
]
140143
args_o = args + ["-o", f"{o}", f"{c}"]

Tools/jit/jit.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1-
// To use preserve_none in JIT builds, we need to declare a separate function pointer with __attribute__((preserve_none)) since this attribute is not supported in < clang 19.
2-
// This is functionally the same as jit_func_native from Include/internal/pycore_jit.h except that it has __attribute__((preserve_none)).
1+
// To use preserve_none in JIT builds, we need to declare a separate function
2+
// pointer with __attribute__((preserve_none)), since this attribute may not be
3+
// supported by the compiler used to build the rest of the interpreter.
34
typedef _Py_CODEUNIT *(*jit_func_preserve_none)(_PyInterpreterFrame *frame, _PyStackRef *stack_pointer, PyThreadState *tstate) __attribute__((preserve_none));

0 commit comments

Comments
 (0)