Skip to content

Commit 6425c4a

Browse files
committed
Accept suggestions
1 parent 712b644 commit 6425c4a

File tree

5 files changed

+115
-61
lines changed

5 files changed

+115
-61
lines changed

Doc/library/pprint.rst

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ Functions
3636
---------
3737

3838
.. function:: pp(object, stream=None, indent=1, width=80, depth=None, *, \
39-
compact=False, sort_dicts=False, underscore_numbers=False, \
40-
block_style=False)
39+
block_style=False, compact=False, sort_dicts=False, \
40+
underscore_numbers=False)
4141

4242
Prints the formatted representation of *object*, followed by a newline.
4343
This function may be used in the interactive interpreter
@@ -107,17 +107,17 @@ Functions
107107

108108

109109
.. function:: pprint(object, stream=None, indent=1, width=80, depth=None, *, \
110-
compact=False, sort_dicts=True, \
111-
underscore_numbers=False, block_style=False)
110+
block_style=False, compact=False, sort_dicts=True, \
111+
underscore_numbers=False)
112112

113113
Alias for :func:`~pprint.pp` with *sort_dicts* set to ``True`` by default,
114114
which would automatically sort the dictionaries' keys,
115115
you might want to use :func:`~pprint.pp` instead where it is ``False`` by default.
116116

117117

118118
.. function:: pformat(object, indent=1, width=80, depth=None, *, \
119-
compact=False, sort_dicts=True, \
120-
underscore_numbers=False, block_style=False)
119+
block_style=False, compact=False, sort_dicts=True, \
120+
underscore_numbers=False)
121121

122122
Return the formatted representation of *object* as a string. *indent*,
123123
*width*, *depth*, *compact*, *sort_dicts*, *underscore_numbers* and *block_style* are
@@ -164,8 +164,8 @@ PrettyPrinter Objects
164164
.. index:: single: ...; placeholder
165165

166166
.. class:: PrettyPrinter(indent=1, width=80, depth=None, stream=None, *, \
167-
compact=False, sort_dicts=True, \
168-
underscore_numbers=False, block_style=False)
167+
block_style=False, compact=False, sort_dicts=True, \
168+
underscore_numbers=False)
169169

170170
Construct a :class:`PrettyPrinter` instance.
171171

Doc/whatsnew/3.14.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1210,7 +1210,7 @@ Deprecated
12101210
.. include:: ../deprecations/pending-removal-in-future.rst
12111211

12121212
Removed
1213-
========
1213+
=======
12141214

12151215
argparse
12161216
--------

Lib/pprint.py

Lines changed: 63 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@
4444

4545

4646
def pprint(object, stream=None, indent=1, width=80, depth=None, *,
47-
compact=False, sort_dicts=True, underscore_numbers=False,
48-
block_style=False):
47+
block_style=False, compact=False, sort_dicts=True,
48+
underscore_numbers=False):
4949
"""Pretty-print a Python object to a stream [default is sys.stdout]."""
5050
printer = PrettyPrinter(
5151
stream=stream, indent=indent, width=width, depth=depth,
@@ -55,8 +55,8 @@ def pprint(object, stream=None, indent=1, width=80, depth=None, *,
5555

5656

5757
def pformat(object, indent=1, width=80, depth=None, *,
58-
compact=False, sort_dicts=True, underscore_numbers=False,
59-
block_style=False):
58+
block_style=False, compact=False, sort_dicts=True,
59+
underscore_numbers=False):
6060
"""Format a Python object into a pretty-printed representation."""
6161
return PrettyPrinter(indent=indent, width=width, depth=depth,
6262
compact=compact, sort_dicts=sort_dicts,
@@ -114,8 +114,8 @@ def _safe_tuple(t):
114114

115115
class PrettyPrinter:
116116
def __init__(self, indent=1, width=80, depth=None, stream=None, *,
117-
compact=False, sort_dicts=True, underscore_numbers=False,
118-
block_style=False):
117+
block_style=False, compact=False, sort_dicts=True,
118+
underscore_numbers=False):
119119
"""Handle pretty printing operations onto a stream using a set of
120120
configured parameters.
121121
@@ -143,8 +143,8 @@ def __init__(self, indent=1, width=80, depth=None, stream=None, *,
143143
144144
block_style
145145
If true, the output will be formatted in a block style similar to
146-
pretty-printed json.dumps() when `indent` is supplied. Incompatible
147-
with compact mode.
146+
pretty-printed json.dumps() when ``indent`` is supplied.
147+
Incompatible with compact mode.
148148
149149
"""
150150
indent = int(indent)
@@ -220,21 +220,22 @@ def _format(self, object, stream, indent, allowance, context, level):
220220
def _format_block_start(self, start_str, indent):
221221
if self._block_style:
222222
return f"{start_str}\n{' ' * indent}"
223-
else:
224-
return start_str
223+
return start_str
225224

226225
def _format_block_end(self, end_str, indent):
227226
if self._block_style:
228227
return f"\n{' ' * indent}{end_str}"
229-
else:
230-
return end_str
228+
return end_str
231229

232230
def _pprint_dataclass(self, object, stream, indent, allowance, context, level):
233231
# Lazy import to improve module import time
234232
from dataclasses import fields as dataclass_fields
235233

236234
cls_name = object.__class__.__name__
237-
indent += len(cls_name) + 1 if not self._block_style else self._indent_per_level
235+
if self._block_style:
236+
indent += self._indent_per_level
237+
else:
238+
indent += len(cls_name) + 1
238239
items = [(f.name, getattr(object, f.name)) for f in dataclass_fields(object) if f.repr]
239240
stream.write(self._format_block_start(cls_name + '(', indent))
240241
self._format_namespace_items(items, stream, indent, allowance, context, level)
@@ -267,10 +268,12 @@ def _pprint_ordered_dict(self, object, stream, indent, allowance, context, level
267268
return
268269
cls = object.__class__
269270
stream.write(cls.__name__ + '(')
270-
recursive_indent = indent + len(cls.__name__) + 1 if not self._block_style else indent
271-
self._format(list(object.items()), stream,
272-
recursive_indent, allowance + 1,
273-
context, level)
271+
if self._block_style:
272+
recursive_indent = indent
273+
else:
274+
recursive_indent = indent + len(cls.__name__) + 1
275+
self._format(list(object.items()), stream, recursive_indent,
276+
allowance + 1, context, level)
274277
stream.write(')')
275278

276279
_dispatch[_collections.OrderedDict.__repr__] = _pprint_ordered_dict
@@ -303,7 +306,8 @@ def _pprint_set(self, object, stream, indent, allowance, context, level):
303306
else:
304307
stream.write(self._format_block_start(typ.__name__ + '({', indent))
305308
endchar = '})'
306-
indent += len(typ.__name__) + 1 if not self._block_style else 0
309+
if not self._block_style:
310+
indent += len(typ.__name__) + 1
307311
object = sorted(object, key=_safe_key)
308312
self._format_items(object, stream, indent, allowance + len(endchar),
309313
context, level)
@@ -373,7 +377,10 @@ def _pprint_bytes(self, object, stream, indent, allowance, context, level):
373377
return
374378
parens = level == 1
375379
if parens:
376-
indent += 1 if not self._block_style else self._indent_per_level
380+
if self._block_style:
381+
indent += self._indent_per_level
382+
else:
383+
indent += 1
377384
allowance += 1
378385
write(self._format_block_start('(', indent))
379386
delim = ''
@@ -392,7 +399,9 @@ def _pprint_bytearray(self, object, stream, indent, allowance, context, level):
392399
write(self._format_block_start('bytearray(', indent))
393400
if self._block_style:
394401
write(' ' * self._indent_per_level)
395-
recursive_indent = indent + 10 if not self._block_style else indent + self._indent_per_level
402+
recursive_indent = indent + self._indent_per_level
403+
else:
404+
recursive_indent = indent + 10
396405
self._pprint_bytes(bytes(object), stream, recursive_indent,
397406
allowance + 1, context, level + 1)
398407
write(self._format_block_end(')', indent))
@@ -401,7 +410,10 @@ def _pprint_bytearray(self, object, stream, indent, allowance, context, level):
401410

402411
def _pprint_mappingproxy(self, object, stream, indent, allowance, context, level):
403412
stream.write('mappingproxy(')
404-
recursive_indent = indent + 13 if not self._block_style else indent
413+
if self._block_style:
414+
recursive_indent = indent
415+
else:
416+
recursive_indent = indent + 13
405417
self._format(object.copy(), stream, recursive_indent, allowance + 1,
406418
context, level)
407419
stream.write(')')
@@ -415,10 +427,14 @@ def _pprint_simplenamespace(self, object, stream, indent, allowance, context, le
415427
cls_name = 'namespace'
416428
else:
417429
cls_name = object.__class__.__name__
418-
indent += len(cls_name) + 1 if not self._block_style else self._indent_per_level
430+
if self._block_style:
431+
indent += self._indent_per_level
432+
else:
433+
indent += len(cls_name) + 1
419434
items = object.__dict__.items()
420435
stream.write(self._format_block_start(cls_name + '(', indent))
421-
self._format_namespace_items(items, stream, indent, allowance, context, level)
436+
self._format_namespace_items(items, stream, indent, allowance, context,
437+
level)
422438
stream.write(self._format_block_end(')', indent - self._indent_per_level))
423439

424440
_dispatch[_types.SimpleNamespace.__repr__] = _pprint_simplenamespace
@@ -434,7 +450,10 @@ def _format_dict_items(self, items, stream, indent, allowance, context,
434450
rep = self._repr(key, context, level)
435451
write(rep)
436452
write(': ')
437-
recursive_indent = indent + len(rep) + 2 if not self._block_style else indent
453+
if self._block_style:
454+
recursive_indent = indent
455+
else:
456+
recursive_indent = indent + len(rep) + 2
438457
self._format(ent, stream, recursive_indent,
439458
allowance if last else 1,
440459
context, level)
@@ -454,7 +473,10 @@ def _format_namespace_items(self, items, stream, indent, allowance, context, lev
454473
# recursive dataclass repr.
455474
write("...")
456475
else:
457-
recursive_indent = indent + len(key) + 1 if not self._block_style else indent
476+
if self._block_style:
477+
recursive_indent = indent
478+
else:
479+
recursive_indent = indent + len(key) + 1
458480
self._format(ent, stream, recursive_indent,
459481
allowance if last else 1,
460482
context, level)
@@ -526,12 +548,13 @@ def _pprint_default_dict(self, object, stream, indent, allowance, context, level
526548
return
527549
rdf = self._repr(object.default_factory, context, level)
528550
cls = object.__class__
529-
indent += len(cls.__name__) + 1 if not self._block_style else 0
530551
if self._block_style:
531552
stream.write('%s(%s, ' % (cls.__name__, rdf))
532553
else:
554+
indent += len(cls.__name__) + 1
533555
stream.write('%s(%s,\n%s' % (cls.__name__, rdf, ' ' * indent))
534-
self._pprint_dict(object, stream, indent, allowance + 1, context, level)
556+
self._pprint_dict(object, stream, indent, allowance + 1, context,
557+
level)
535558
stream.write(')')
536559

537560
_dispatch[_collections.defaultdict.__repr__] = _pprint_default_dict
@@ -547,9 +570,11 @@ def _pprint_counter(self, object, stream, indent, allowance, context, level):
547570
if self._indent_per_level > 0 and self._block_style:
548571
stream.write(self._indent_per_level * ' ')
549572
items = object.most_common()
550-
recursive_indent = indent + len(cls.__name__) + 1 if not self._block_style else indent
551-
self._format_dict_items(items, stream,
552-
recursive_indent, allowance + 2,
573+
if self._block_style:
574+
recursive_indent = indent
575+
else:
576+
recursive_indent = indent + len(cls.__name__) + 1
577+
self._format_dict_items(items, stream, recursive_indent, allowance + 2,
553578
context, level)
554579
stream.write(self._format_block_end('})', indent))
555580

@@ -560,8 +585,12 @@ def _pprint_chain_map(self, object, stream, indent, allowance, context, level):
560585
stream.write(repr(object))
561586
return
562587
cls = object.__class__
563-
stream.write(self._format_block_start(cls.__name__ + '(', indent + self._indent_per_level))
564-
indent += len(cls.__name__) + 1 if not self._block_style else self._indent_per_level
588+
stream.write(self._format_block_start(cls.__name__ + '(',
589+
indent + self._indent_per_level))
590+
if self._block_style:
591+
indent += self._indent_per_level
592+
else:
593+
indent += len(cls.__name__) + 1
565594
for i, m in enumerate(object.maps):
566595
if i == len(object.maps) - 1:
567596
self._format(m, stream, indent, allowance + 1, context, level)
@@ -578,7 +607,8 @@ def _pprint_deque(self, object, stream, indent, allowance, context, level):
578607
return
579608
cls = object.__class__
580609
stream.write(self._format_block_start(cls.__name__ + '([', indent))
581-
indent += len(cls.__name__) + 1 if not self._block_style else 0
610+
if not self._block_style:
611+
indent += len(cls.__name__) + 1
582612
if object.maxlen is None:
583613
self._format_items(object, stream, indent, allowance + 2,
584614
context, level)

0 commit comments

Comments
 (0)