Add critical section around ZSTD_DCtx_setParameter

emmatyping · emmatyping · commit 676054504316 · 2025-05-01T16:46:50.000-07:00
diff --git a/Modules/_zstd/decompressor.c b/Modules/_zstd/decompressor.c
@@ -104,7 +104,9 @@ _PyZstd_set_d_parameters(ZstdDecompressor *self, PyObject *options)
         }
 
         /* Set parameter to compression context */
+        Py_BEGIN_CRITICAL_SECTION(self);
         zstd_ret = ZSTD_DCtx_setParameter(self->dctx, key_v, value_v);
+        Py_END_CRITICAL_SECTION();
 
         /* Check error */
         if (ZSTD_isError(zstd_ret)) {

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,9 @@ _PyZstd_set_d_parameters(ZstdDecompressor self, PyObject options)`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`/* Set parameter to compression context */`
	`107`	`+ Py_BEGIN_CRITICAL_SECTION(self);`
`107`	`108`	`zstd_ret = ZSTD_DCtx_setParameter(self->dctx, key_v, value_v);`
	`109`	`+ Py_END_CRITICAL_SECTION();`
`108`	`110`
`109`	`111`	`/* Check error */`
`110`	`112`	`if (ZSTD_isError(zstd_ret)) {`