Apply suggestions from code review

iritkatriel · eendebakpt · web-flow · commit 69112e93466d · 2025-01-11T23:49:57.000Z
Co-authored-by: Pieter Eendebak &lt;pieter.eendebak@gmail.com&gt;
diff --git a/Python/specialize.c b/Python/specialize.c
@@ -2521,8 +2521,8 @@ _Py_Specialize_BinaryOp(_PyStackRef lhs_st, _PyStackRef rhs_st, _Py_CODEUNIT *in
     _PyBinaryOpCache *cache = (_PyBinaryOpCache *)(instr + 1);
     if (instr->op.code == BINARY_OP_EXTEND) {
         void *data = read_void(cache->external_cache);
-        free_binary_op_specialization_descr(data);
         write_void(cache->external_cache, NULL);
+        free_binary_op_specialization_descr(data);
     }
 
     switch (oparg) {

Original file line number	Diff line number	Diff line change
`@@ -2521,8 +2521,8 @@ _Py_Specialize_BinaryOp(_PyStackRef lhs_st, _PyStackRef rhs_st, _Py_CODEUNIT *in`
`2521`	`2521`	`_PyBinaryOpCache cache = (_PyBinaryOpCache )(instr + 1);`
`2522`	`2522`	`if (instr->op.code == BINARY_OP_EXTEND) {`
`2523`	`2523`	`void *data = read_void(cache->external_cache);`
`2524`		`- free_binary_op_specialization_descr(data);`
`2525`	`2524`	`write_void(cache->external_cache, NULL);`
	`2525`	`+ free_binary_op_specialization_descr(data);`
`2526`	`2526`	`}`
`2527`	`2527`
`2528`	`2528`	`switch (oparg) {`