fixup! bpo-22433: do not consider "--foo='bar baz'" to be a positional argument

Author: blueyed

Lib/argparse.py

@@ -2223,7 +2223,8 @@ def _parse_optional(self, arg_string):
             if not self._has_negative_number_optionals:
                 return None
 
-        # if it contains a space (before any equal sign), it was meant to be a positional
+        # if it contains a space (before any equal sign), it was meant to be a
+        # positional
         if ' ' in arg_string.split("=", 1)[0]:
             return None
 

Lib/test/test_argparse.py

@@ -2022,7 +2022,7 @@ def test_parse_known_args(self):
             self.parser.parse_known_args(['0.5', '--opt="with space"']),
             (NS(foo=False, bar=0.5), ['--opt="with space"']),
         )
-        self.assertRaisesRegexp(
+        self.assertRaisesRegex(
             ArgumentParserError,
             "invalid choice: '--opt with space'",
             self.parser.parse_known_args,

Misc/NEWS.d/next/Library/2020-07-06-15-25-29.bpo-22433.JBnwdX.rst

@@ -0,0 +1,2 @@
+Fixed handling of "--foo='bar baz'" as non-positional argument with
+:mod:`argparse`.