correct false positives

Author: picnixz

Lib/test/.ruff.toml

@@ -13,15 +13,6 @@ extend-exclude = [
 ]
 
 [lint]
-# Variables with single letters and an optional numeric prefix
-# are considered to be used, so that we do not need to always
-# add a 'F811' suppression.
-dummy-variable-rgx = """(?x:^(      \
-    _+                              \
-    |(_+[a-zA-Z0-9_]*[a-zA-Z0-9]+?) \
-    |([a-zA-Z][0-9]*)               \
-)$)"""
-
 select = [
     "F811",  # Redefinition of unused variable (useful for finding test methods with the same name)
 ]

Lib/test/test_dataclasses/__init__.py

@@ -771,12 +771,12 @@ class Point:
 
                 # Because this is a ClassVar, it can be mutable.
                 @dataclass
-                class C:
+                class UsesMutableClassVar:
                     z: ClassVar[typ] = typ()
 
                 # Because this is a ClassVar, it can be mutable.
                 @dataclass
-                class C:
+                class UsesMutableClassVarWithSubType:
                     x: ClassVar[typ] = Subclass()
 
     def test_deliberately_mutable_defaults(self):
@@ -4864,21 +4864,21 @@ class A:
 
         # But this usage is okay, since it's not using KW_ONLY.
         @dataclass
-        class A:
+        class NoDuplicateKwOnlyAnnotation:
             a: int
             _: KW_ONLY
             b: int
             c: int = field(kw_only=True)
 
         # And if inheriting, it's okay.
         @dataclass
-        class A:
+        class BaseUsesKwOnly:
             a: int
             _: KW_ONLY
             b: int
             c: int
         @dataclass
-        class B(A):
+        class SubclassUsesKwOnly(BaseUsesKwOnly):
             _: KW_ONLY
             d: int
 

Lib/test/test_descr.py

@@ -1192,10 +1192,9 @@ class C(object):
             pass
         else:
             self.fail("[''] slots not caught")
-        class C(object):
+
+        class WithValidIdentifiers(object):
             __slots__ = ["a", "a_b", "_a", "A0123456789Z"]
-        # XXX(nnorwitz): was there supposed to be something tested
-        # from the class above?
 
         # Test a single string is not expanded as a sequence.
         class C(object):