Address the review

wrongnull · wrongnull · commit 7227e3ed103e · 2024-12-28T02:10:07.000+03:00
diff --git a/Objects/object.c b/Objects/object.c
@@ -1715,16 +1715,14 @@ _PyObject_GenericGetAttrWithDict(PyObject *obj, PyObject *name,
             dict = (PyObject *)_PyObject_GetManagedDict(obj);
         }
         else {
-            Py_BEGIN_CRITICAL_SECTION(obj);
-#ifdef DISABLE_GIL
-            PyObject **dictptr = _Py_atomic_load_ptr(_PyObject_ComputedDictPointer(obj));
-#else
             PyObject **dictptr = _PyObject_ComputedDictPointer(obj);
-#endif
             if (dictptr) {
+#ifdef Py_GIL_DISABLED
+                dict = _Py_atomic_load_ptr_acquire(dictptr);
+#else
                 dict = *dictptr;
+#endif
             }
-            Py_END_CRITICAL_SECTION();
         }
     }
     if (dict != NULL) {

Original file line number	Diff line number	Diff line change
`@@ -1715,16 +1715,14 @@ _PyObject_GenericGetAttrWithDict(PyObject obj, PyObject name,`
`1715`	`1715`	`dict = (PyObject *)_PyObject_GetManagedDict(obj);`
`1716`	`1716`	`}`
`1717`	`1717`	`else {`
`1718`		`- Py_BEGIN_CRITICAL_SECTION(obj);`
`1719`		`-#ifdef DISABLE_GIL`
`1720`		`- PyObject **dictptr = _Py_atomic_load_ptr(_PyObject_ComputedDictPointer(obj));`
`1721`		`-#else`
`1722`	`1718`	`PyObject **dictptr = _PyObject_ComputedDictPointer(obj);`
`1723`		`-#endif`
`1724`	`1719`	`if (dictptr) {`
	`1720`	`+#ifdef Py_GIL_DISABLED`
	`1721`	`+ dict = _Py_atomic_load_ptr_acquire(dictptr);`
	`1722`	`+#else`
`1725`	`1723`	`dict = *dictptr;`
	`1724`	`+#endif`
`1726`	`1725`	`}`
`1727`		`- Py_END_CRITICAL_SECTION();`
`1728`	`1726`	`}`
`1729`	`1727`	`}`
`1730`	`1728`	`if (dict != NULL) {`