fix review idea

Signed-off-by: Manjusaka <[email protected]>

Author: Zheaoli

Lib/test/test_pty.py

@@ -231,8 +231,7 @@ def test_fork(self):
                 os._exit(2)
             os._exit(4)
         else:
-            flags = fcntl.fcntl(master_fd, fcntl.F_GETFD)
-            self.assertTrue(flags & fcntl.FD_CLOEXEC)
+            self.assertFalse(os.get_inheritable(master_fd))
             debug("Waiting for child (%d) to finish." % pid)
             # In verbose mode, we have to consume the debug output from the
             # child or the child will block, causing this test to hang in the

Misc/NEWS.d/next/Library/2025-09-29-14-15-20.gh-issue-139184.dNl9O4.rst

@@ -1 +1 @@
-Set O_CLOEXEC for master_fd when call os.forkpty
+:func:``os.forkpty`` does now make the returned file descriptor non-inheritable.

Modules/posixmodule.c

@@ -9060,8 +9060,11 @@ os_forkpty_impl(PyObject *module)
         /* parent: release the import lock. */
         PyOS_AfterFork_Parent();
         /* set O_CLOEXEC on master_fd */
-        if (_Py_set_inheritable(master_fd, 0, NULL) < 0)
-            goto error;
+        if (_Py_set_inheritable(master_fd, 0, NULL) < 0) {
+            close(master_fd);
+            return NULL;
+        }
+
         // After PyOS_AfterFork_Parent() starts the world to avoid deadlock.
         if (warn_about_fork_with_threads("forkpty") < 0)
             return NULL;
@@ -9071,10 +9074,6 @@ os_forkpty_impl(PyObject *module)
     }
 
     return Py_BuildValue("(Ni)", PyLong_FromPid(pid), master_fd);
-error:
-    if (master_fd != -1)
-        close(master_fd);
-    return NULL;
 }
 #endif /* HAVE_FORKPTY */