Skip to content

Commit 77b4ed2

Browse files
miss-islingtonHoKim98AA-Turner
authored
[3.14] gh-138489: Add missing build-details.json step for building wasm (GH-139302) (GH-139557)
(cherry picked from commit db53ca3) Signed-off-by: Ho Kim <[email protected]> Co-authored-by: Ho Kim <[email protected]> Co-authored-by: Adam Turner <[email protected]>
1 parent 29cffb1 commit 77b4ed2

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

Makefile.pre.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -801,7 +801,7 @@ build_all: check-clean-src check-app-store-compliance $(BUILDPYTHON) platform sh
801801

802802
.PHONY: build_wasm
803803
build_wasm: check-clean-src $(BUILDPYTHON) platform sharedmods \
804-
python-config checksharedmods
804+
python-config checksharedmods build-details.json
805805

806806
.PHONY: build_emscripten
807807
build_emscripten: build_wasm web_example web_example_pyrepl_jspi
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
When cross-compiling for WASI by ``build_wasm`` or ``build_emscripten``, the
2+
``build-details.json`` step is now included in the build process, just like
3+
with native builds.
4+
5+
This fixes the ``libinstall`` task which requires the ``build-details.json``
6+
file during the process.

0 commit comments

Comments
 (0)