Skip to content

Commit 786a248

Browse files
committed
Move os.mkdir and addCleanup functions beginning of the testcases
1 parent 54188bd commit 786a248

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

Lib/test/test_shelve.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,9 @@ def test_default_protocol(self):
167167
self.assertEqual(s._protocol, pickle.DEFAULT_PROTOCOL)
168168

169169
def test_custom_serializer_and_deserializer(self):
170+
os.mkdir(self.dirname)
171+
self.addCleanup(os_helper.rmtree, self.dirname)
172+
170173
def serializer(obj, protocol):
171174
if isinstance(obj, (bytes, bytearray, str)):
172175
if protocol == 5:
@@ -190,9 +193,6 @@ def deserializer(data):
190193
f"Unsupported type for deserialization: {type(data)}"
191194
)
192195

193-
os.mkdir(self.dirname)
194-
self.addCleanup(os_helper.rmtree, self.dirname)
195-
196196
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
197197
with self.subTest(proto=proto):
198198
with shelve.open(
@@ -258,6 +258,8 @@ def deserializer(data):
258258

259259
def test_custom_serializer_and_deserializer_bsd_db_shelf(self):
260260
berkeleydb = import_helper.import_module("berkeleydb")
261+
os.mkdir(self.dirname)
262+
self.addCleanup(os_helper.rmtree, self.dirname)
261263

262264
def serializer(obj, protocol=None):
263265
data = obj.__class__.__name__
@@ -268,9 +270,6 @@ def serializer(obj, protocol=None):
268270
def deserializer(data):
269271
return data.decode("utf-8")
270272

271-
os.mkdir(self.dirname)
272-
self.addCleanup(os_helper.rmtree, self.dirname)
273-
274273
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
275274
with self.subTest(proto=5):
276275
with shelve.BsdDbShelf(

0 commit comments

Comments
 (0)