Skip to content

Commit 791743b

Browse files
committed
simplify assertRaises calls in test_missing_custom_deserializer & test_missing_custom_serializer
1 parent d1bb227 commit 791743b

File tree

1 file changed

+6
-17
lines changed

1 file changed

+6
-17
lines changed

Lib/test/test_shelve.py

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -413,28 +413,17 @@ def test_missing_custom_deserializer(self):
413413
def serializer(obj, protocol=None):
414414
pass
415415

416-
with self.assertRaises(shelve.ShelveError):
417-
shelve.Shelf({},
418-
protocol=2, writeback=False, serializer=serializer)
419-
420-
with self.assertRaises(shelve.ShelveError):
421-
shelve.BsdDbShelf({},
422-
protocol=2,
423-
writeback=False, serializer=serializer)
416+
kwargs = dict(protocol=2, writeback=False, serializer=serializer)
417+
self.assertRaises(shelve.ShelveError, shelve.Shelf, {}, **kwargs)
418+
self.assertRaises(shelve.ShelveError, shelve.BsdDbShelf, {}, **kwargs)
424419

425420
def test_missing_custom_serializer(self):
426421
def deserializer(data):
427422
pass
428423

429-
with self.assertRaises(shelve.ShelveError):
430-
shelve.Shelf({},
431-
protocol=2,
432-
writeback=False, deserializer=deserializer)
433-
434-
with self.assertRaises(shelve.ShelveError):
435-
shelve.BsdDbShelf({},
436-
protocol=2,
437-
writeback=False, deserializer=deserializer)
424+
kwargs = dict(protocol=2, writeback=False, deserializer=deserializer)
425+
self.assertRaises(shelve.ShelveError, shelve.Shelf, {}, **kwargs)
426+
self.assertRaises(shelve.ShelveError, shelve.BsdDbShelf, {}, **kwargs)
438427

439428

440429
class TestShelveBase:

0 commit comments

Comments
 (0)