[3.13] GH-140058: Clear key and value if PyTuple_New fails in dictiter_iternextitem (GH-140059) (#140108)

miss-islington · sergey-miryanov · web-flow · commit 7992a2951234 · 2025-10-14T13:40:13.000Z
GH-140058: Clear key and value if `PyTuple_New` fails in `dictiter_iternextitem` (GH-140059) (cherry picked from commit ded59f7) Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>
diff --git a/Objects/dictobject.c b/Objects/dictobject.c
@@ -5611,8 +5611,11 @@ dictiter_iternextitem(PyObject *self)
         }
         else {
             result = PyTuple_New(2);
-            if (result == NULL)
+            if (result == NULL) {
+                Py_DECREF(key);
+                Py_DECREF(value);
                 return NULL;
+            }
             PyTuple_SET_ITEM(result, 0, key);
             PyTuple_SET_ITEM(result, 1, value);
         }

Original file line number	Diff line number	Diff line change
`@@ -5611,8 +5611,11 @@ dictiter_iternextitem(PyObject *self)`
`5611`	`5611`	`}`
`5612`	`5612`	`else {`
`5613`	`5613`	`result = PyTuple_New(2);`
`5614`		`- if (result == NULL)`
	`5614`	`+ if (result == NULL) {`
	`5615`	`+ Py_DECREF(key);`
	`5616`	`+ Py_DECREF(value);`
`5615`	`5617`	`return NULL;`
	`5618`	`+ }`
`5616`	`5619`	`PyTuple_SET_ITEM(result, 0, key);`
`5617`	`5620`	`PyTuple_SET_ITEM(result, 1, value);`
`5618`	`5621`	`}`