Skip to content

Commit 8035854

Browse files
committed
Address code review
1 parent 698b58e commit 8035854

File tree

8 files changed

+15
-36
lines changed

8 files changed

+15
-36
lines changed

Include/internal/pycore_opcode_metadata.h

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Include/internal/pycore_uop_ids.h

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Include/internal/pycore_uop_metadata.h

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Python/bytecodes.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1158,9 +1158,9 @@ dummy_func(
11581158
}
11591159

11601160
macro(STORE_SUBSCR_DICT) =
1161-
_GUARD_NOS_DICT + unused/1 + _STORE_SUBSCR_DICT + POP_TOP + POP_TOP;
1161+
_GUARD_NOS_DICT + unused/1 + _STORE_SUBSCR_DICT + POP_TOP;
11621162

1163-
op(_STORE_SUBSCR_DICT, (value, dict_st, sub -- st, sb)) {
1163+
op(_STORE_SUBSCR_DICT, (value, dict_st, sub -- st)) {
11641164
PyObject *dict = PyStackRef_AsPyObjectBorrow(dict_st);
11651165

11661166
assert(PyDict_CheckExact(dict));
@@ -1171,9 +1171,8 @@ dummy_func(
11711171
if (err) {
11721172
ERROR_NO_POP();
11731173
}
1174-
INPUTS_DEAD();
1174+
DEAD(dict_st);
11751175
st = dict_st;
1176-
sb = sub;
11771176
}
11781177

11791178
inst(DELETE_SUBSCR, (container, sub --)) {

Python/executor_cases.c.h

Lines changed: 3 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Python/generated_cases.c.h

Lines changed: 1 addition & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Python/optimizer_bytecodes.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,9 @@ dummy_func(void) {
109109
ss = sub_st;
110110
}
111111

112-
op(_STORE_SUBSCR_DICT, (value, dict_st, sub -- st, sb)) {
112+
op(_STORE_SUBSCR_DICT, (value, dict_st, sub -- st)) {
113113
(void)value;
114114
st = dict_st;
115-
sb = sub;
116115
}
117116

118117
op(_PUSH_NULL, (-- res)) {

Python/optimizer_cases.c.h

Lines changed: 2 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)