Skip to content

Commit 810f9cb

Browse files
Update Lib/test/test_email/test_email.py
Co-authored-by: Bénédikt Tran <[email protected]>
1 parent 151e146 commit 810f9cb

File tree

1 file changed

+11
-16
lines changed

1 file changed

+11
-16
lines changed

Lib/test/test_email/test_email.py

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -739,23 +739,18 @@ def test_invalid_header_names(self):
739739
('Header\x7F', 'Non-ASCII character'),
740740
('Header\x80', 'Extended ASCII'),
741741
]
742-
for thispolicy in (email.policy.default, email.policy.compat32):
743-
for method in ('__setitem__', 'add_header'):
742+
for policy in (email.policy.default, email.policy.compat32):
743+
for setter in (Message.__setitem__, Message.add_header):
744744
for name, value in invalid_headers:
745-
with self.subTest(
746-
name=name,
747-
description=value,
748-
policy=thispolicy.__class__.__name__,
749-
method=method,
750-
):
751-
message = Message(policy=thispolicy)
752-
class_method = getattr(message, method)
753-
with self.assertRaisesRegex(
754-
ValueError,
755-
'(?i)(?=.*invalid)(?=.*header)(?=.*name)'
756-
) as cm:
757-
class_method(name, value)
758-
self.assertIn(f"{name!r}", str(cm.exception))
745+
self.do_test_invalid_header_names(policy, setter, name, value)
746+
747+
def do_test_invalid_header_names(self, policy, setter, name, value):
748+
with self.subTest(policy=policy, setter=setter, name=name, value=value):
749+
message = Message(policy=policy)
750+
pattern = r'(?i)(?=.*invalid)(?=.*header)(?=.*name)'
751+
with self.assertRaisesRegex(ValueError, pattern) as cm:
752+
setter(message, name, value)
753+
self.assertIn(f"{name!r}", str(cm.exception))
759754

760755

761756
def test_binary_quopri_payload(self):

0 commit comments

Comments
 (0)