Skip to content

Commit 8326190

Browse files
committed
Use skip=False by default
1 parent 420bddd commit 8326190

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

Lib/test/test_pyrepl/test_pyrepl.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def run_repl(
4444
*,
4545
cmdline_args: list[str] | None = None,
4646
cwd: str | None = None,
47-
skip: bool = True,
47+
skip: bool = False,
4848
) -> tuple[str, int]:
4949
temp_dir = None
5050
if cwd is None:
@@ -1265,7 +1265,7 @@ def test_dumb_terminal_exits_cleanly(self):
12651265
env = os.environ.copy()
12661266
env.pop('PYTHON_BASIC_REPL', None)
12671267
env.update({"TERM": "dumb"})
1268-
output, exit_code = self.run_repl("exit()\n", env=env, skip=False)
1268+
output, exit_code = self.run_repl("exit()\n", env=env)
12691269
self.assertEqual(exit_code, 0)
12701270
self.assertIn("warning: can't use pyrepl", output)
12711271
self.assertNotIn("Exception", output)
@@ -1287,7 +1287,7 @@ def setUp(self):
12871287
def test_exposed_globals_in_repl(self):
12881288
pre = "['__builtins__'"
12891289
post = "'__loader__', '__name__', '__package__', '__spec__']"
1290-
output, exit_code = self.run_repl(["sorted(dir())", "exit()"])
1290+
output, exit_code = self.run_repl(["sorted(dir())", "exit()"], skip=True)
12911291
self.assertEqual(exit_code, 0)
12921292

12931293
# if `__main__` is not a file (impossible with pyrepl)
@@ -1339,13 +1339,15 @@ def _run_repl_globals_test(self, expectations, *, as_file=False, as_module=False
13391339
commands,
13401340
cmdline_args=[str(mod)],
13411341
env=clean_env,
1342+
skip=True,
13421343
)
13431344
elif as_module:
13441345
output, exit_code = self.run_repl(
13451346
commands,
13461347
cmdline_args=["-m", "blue.calx"],
13471348
env=clean_env,
13481349
cwd=td,
1350+
skip=True,
13491351
)
13501352
else:
13511353
self.fail("Choose one of as_file or as_module")
@@ -1387,7 +1389,7 @@ def test_python_basic_repl(self):
13871389
"exit()\n")
13881390

13891391
env.pop("PYTHON_BASIC_REPL", None)
1390-
output, exit_code = self.run_repl(commands, env=env)
1392+
output, exit_code = self.run_repl(commands, env=env, skip=True)
13911393
self.assertEqual(exit_code, 0)
13921394
self.assertIn("True", output)
13931395
self.assertNotIn("False", output)
@@ -1454,7 +1456,7 @@ def check(output, exitcode):
14541456
self.assertIn("division by zero", output)
14551457
self.assertEqual(exitcode, 0)
14561458
env.pop("PYTHON_BASIC_REPL", None)
1457-
output, exit_code = self.run_repl(commands, env=env)
1459+
output, exit_code = self.run_repl(commands, env=env, skip=True)
14581460
check(output, exit_code)
14591461

14601462
env["PYTHON_BASIC_REPL"] = "1"
@@ -1492,7 +1494,7 @@ def test_not_wiping_history_file(self):
14921494
def test_correct_filename_in_syntaxerrors(self):
14931495
env = os.environ.copy()
14941496
commands = "a b c\nexit()\n"
1495-
output, exit_code = self.run_repl(commands, env=env)
1497+
output, exit_code = self.run_repl(commands, env=env, skip=True)
14961498
self.assertIn("SyntaxError: invalid syntax", output)
14971499
self.assertIn("<python-input-0>", output)
14981500
commands = " b\nexit()\n"
@@ -1519,7 +1521,7 @@ def test_proper_tracebacklimit(self):
15191521
env.pop("PYTHON_BASIC_REPL", None)
15201522
with self.subTest(set_tracebacklimit=set_tracebacklimit,
15211523
basic_repl=basic_repl):
1522-
output, exit_code = self.run_repl(commands, env=env)
1524+
output, exit_code = self.run_repl(commands, env=env, skip=True)
15231525
self.assertIn("in x1", output)
15241526
if set_tracebacklimit:
15251527
self.assertNotIn("in x2", output)
@@ -1560,7 +1562,7 @@ def test_readline_history_file(self):
15601562
def test_history_survive_crash(self):
15611563
env = os.environ.copy()
15621564
commands = "1\nexit()\n"
1563-
output, exit_code = self.run_repl(commands, env=env)
1565+
output, exit_code = self.run_repl(commands, env=env, skip=True)
15641566

15651567
with tempfile.NamedTemporaryFile() as hfile:
15661568
env["PYTHON_HISTORY"] = hfile.name

0 commit comments

Comments
 (0)