reduce exported scope

Author: picnixz

Modules/_hashlib/hashlib_buffer.c

@@ -38,3 +38,28 @@ _Py_hashlib_data_argument(PyObject **res, PyObject *data, PyObject *string)
         return -1;
     }
 }
+
+int
+_Py_hashlib_get_buffer_view(PyObject *obj, Py_buffer *view)
+{
+    if (PyUnicode_Check(obj)) {
+        PyErr_SetString(PyExc_TypeError,
+                        "Strings must be encoded before hashing");
+        return -1;
+    }
+    if (!PyObject_CheckBuffer(obj)) {
+        PyErr_SetString(PyExc_TypeError,
+                        "object supporting the buffer API required");
+        return -1;
+    }
+    if (PyObject_GetBuffer(obj, view, PyBUF_SIMPLE) == -1) {
+        return -1;
+    }
+    if (view->ndim > 1) {
+        PyErr_SetString(PyExc_BufferError,
+                        "Buffer must be single dimension");
+        PyBuffer_Release(view);
+        return -1;
+    }
+    return 0;
+}

Modules/_hashlib/hashlib_buffer.h

@@ -3,36 +3,26 @@
 
 #include "Python.h"
 
+/*
+ * Allow to use the 'data' or 'string' keyword in hashlib.new()
+ * and other hash functions named constructors.
+ *
+ * - If 'data' and 'string' are both non-NULL, set an exception and return -1.
+ * - If 'data' and 'string' are both NULL, set '*res' to NULL and return 0.
+ * - Otherwise, set '*res' to 'data' or 'string' and return 1. A deprecation
+ *   warning is set when 'string' is specified.
+ */
+extern int
+_Py_hashlib_data_argument(PyObject **res, PyObject *data, PyObject *string);
+
 /*
  * Obtain a buffer view from a buffer-like object 'obj'.
  *
  * On success, store the result in 'view' and return 0.
  * On error, set an exception and return -1.
  */
-static inline int
-_Py_hashlib_get_buffer_view(PyObject *obj, Py_buffer *view)
-{
-    if (PyUnicode_Check(obj)) {
-        PyErr_SetString(PyExc_TypeError,
-                        "Strings must be encoded before hashing");
-        return -1;
-    }
-    if (!PyObject_CheckBuffer(obj)) {
-        PyErr_SetString(PyExc_TypeError,
-                        "object supporting the buffer API required");
-        return -1;
-    }
-    if (PyObject_GetBuffer(obj, view, PyBUF_SIMPLE) == -1) {
-        return -1;
-    }
-    if (view->ndim > 1) {
-        PyErr_SetString(PyExc_BufferError,
-                        "Buffer must be single dimension");
-        PyBuffer_Release(view);
-        return -1;
-    }
-    return 0;
-}
+extern int
+_Py_hashlib_get_buffer_view(PyObject *obj, Py_buffer *view);
 
 /*
  * Call _Py_hashlib_get_buffer_view() and check if it succeeded.
@@ -51,18 +41,4 @@ _Py_hashlib_get_buffer_view(PyObject *obj, Py_buffer *view)
 #define GET_BUFFER_VIEW_OR_ERROUT(OBJ, VIEW)                \
     GET_BUFFER_VIEW_OR_ERROR(OBJ, VIEW, return NULL)
 
-/*
- * Allow to use the 'data' or 'string' keyword in hashlib.new()
- * and other hash functions named constructors.
- *
- * - If 'data' and 'string' are both non-NULL, set an exception and return -1.
- * - If 'data' and 'string' are both NULL, set '*res' to NULL and return 0.
- * - Otherwise, set '*res' to 'data' or 'string' and return 1. A deprecation
- *   warning is set when 'string' is specified.
- *
- * The symbol is exported for '_hashlib' and HACL*-based extension modules.
- */
-PyAPI_FUNC(int)
-_Py_hashlib_data_argument(PyObject **res, PyObject *data, PyObject *string);
-
 #endif // !_HASHLIB_HASHLIB_BUFFER_H