Skip to content

Commit 8ae38c7

Browse files
Apply changes from code review
Co-Authored-By: Tomas R. <[email protected]>
1 parent d22f165 commit 8ae38c7

File tree

3 files changed

+31
-31
lines changed

3 files changed

+31
-31
lines changed

Python/optimizer_analysis.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,6 @@ optimize_uops(
519519
return trace_len;
520520

521521
pop_2_error:
522-
pop_1_error:
523522
error:
524523
DPRINTF(3, "\n");
525524
DPRINTF(1, "Encountered error in abstract interpreter\n");

Python/optimizer_cases.c.h

Lines changed: 27 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Tools/cases_generator/optimizer_generator.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ def emit_stackref_override(
141141
inst: Instruction | None,
142142
) -> bool:
143143
self.out.emit(tkn)
144-
self.out.emit("_stackref")
144+
self.out.emit("_stackref ")
145145
return True
146146

147147
def write_uop_pure_evaluation_region_header(
@@ -152,9 +152,10 @@ def write_uop_pure_evaluation_region_header(
152152
emitter = OptimizerConstantEmitter(out, {}, uop)
153153
emitter.emit("if (\n")
154154
assert len(uop.stack.inputs) > 0, "Pure operations must have at least 1 input"
155-
for inp in uop.stack.inputs:
155+
for inp in uop.stack.inputs[:-1]:
156156
emitter.emit(f"sym_is_const(ctx, {inp.name}) &&\n")
157-
emitter.emit("1) {\n")
157+
emitter.emit(f"sym_is_const(ctx, {uop.stack.inputs[-1].name})\n")
158+
emitter.emit(') {\n')
158159
# Declare variables, before they are shadowed.
159160
for inp in uop.stack.inputs:
160161
if inp.used:

0 commit comments

Comments
 (0)