Skip to content

Commit 8b5638d

Browse files
encukoupicnixz
andauthored
Apply suggestions from code review
Co-authored-by: Bénédikt Tran <[email protected]>
1 parent 2d4e590 commit 8b5638d

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

Modules/pyexpat.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ typedef struct {
9999
#define CHARACTER_DATA_BUFFER_SIZE 8192
100100

101101
// A generic function type for storage.
102-
// To avoid undefined behavior, a handler needs to be cast to the correct
102+
// To avoid undefined behaviors, a handler must be cast to the correct
103103
// function type before it's called; see SETTER_WRAPPER below.
104104
typedef void (*xmlhandler)(void);
105105

@@ -2224,10 +2224,10 @@ clear_handlers(xmlparseobject *self, int initial)
22242224
}
22252225
}
22262226

2227-
/* To avoid undefined behavior, a function needs to be *called* via a function
2227+
/* To avoid undefined behaviors, a function must be *called* via a function
22282228
* pointer of the correct type.
2229-
* So, for each `XML_Set*` function, we define a wrapper that calls the
2230-
* `XML_Set*` with its argument cast to the appropriate type.
2229+
* So, for each `XML_Set*` function, we define a wrapper that calls `XML_Set*`
2230+
* with its argument cast to the appropriate type.
22312231
*/
22322232

22332233
typedef void (*parser_only)(void *);
@@ -2293,6 +2293,7 @@ SETTER_WRAPPER(AttlistDeclHandler, attlist_decl)
22932293
#if XML_COMBINED_VERSION >= 19504
22942294
SETTER_WRAPPER(SkippedEntityHandler, parser_and_data_and_int)
22952295
#endif
2296+
#undef SETTER_WRAPPER
22962297

22972298
static struct HandlerInfo handler_info[] = {
22982299

0 commit comments

Comments
 (0)